Skip to content

chore: Replace serde_yaml with yaml_serde - #1011

Merged
razvan merged 3 commits into
mainfrom
chore/yaml-serde
Oct 14, 2026
Merged

razvan merged 3 commits into
mainfrom
chore/yaml-serde

Conversation

@razvan

@razvan razvan commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#898

$  ./scripts/run-tests --skip-operator nifi --test-suite smoke-latest
--- PASS: kuttl (729.64s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_nifi-2.12.0_use-zookeeper-manager-true_zookeeper-latest-3.9.6_openshift-false_listener-class-external-unstable (729.63s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Oct 14, 2026
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 14, 2026
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 14, 2026

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan
razvan enabled auto-merge October 14, 2026 15:43
@razvan
razvan disabled auto-merge October 14, 2026 15:44
@razvan
razvan added this pull request to the merge queue Oct 14, 2026
Merged via the queue into main with commit 46a4f8f Oct 14, 2026
13 checks passed
@razvan
razvan deleted the chore/yaml-serde branch October 14, 2026 15:56
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Oct 19, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants