Skip to content

chore!: Replace serde_yaml with yaml_serde - #1298

Merged
Techassi merged 3 commits into
mainfrom
chore/migrate-to-yaml_serde
Oct 13, 2026
Merged

Techassi merged 3 commits into
mainfrom
chore/migrate-to-yaml_serde

Conversation

@Techassi

Copy link
Copy Markdown
Member

In #1293, we had to temporarily allow the advisory regarding the unmaintained unsafe-libyaml crate.

The yaml_serde is a drop-in replacement for the deprecated serde_yaml and is officially maintained by the YAML organization, see https://github.com/yaml/yaml-serde.

In the future, we can also opt to maintain our own fork or switch to serde-saphyr, which is however not a drop-in replacement. I have a local, partial migration ready if we ever decide to go down that route.

Comment thread crates/stackable-versioned-macros/src/codegen/item/field.rs
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 12, 2026

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi changed the title chore: Replace serde_yaml with yaml_serde chore!: Replace serde_yaml with yaml_serde Oct 13, 2026
@Techassi
Techassi requested a review from NickLarsenNZ October 13, 2026 09:08

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: In Progress to Development: In Review in Stackable Engineering Oct 13, 2026
@Techassi
Techassi enabled auto-merge October 13, 2026 09:14
@Techassi
Techassi added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 19934e0 Oct 13, 2026
5 checks passed
@Techassi
Techassi deleted the chore/migrate-to-yaml_serde branch October 13, 2026 09:27
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Oct 13, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants