Repository navigation
Add support for fan RPM readings in ThermalSubsystem - #17
Merged
Merged
Conversation
MurrayGroves
force-pushed
the
thermal-subsystem-fans
branch
from
October 29, 2026 14:02
db0f8f9 to
2af2ec1
Compare
dougszumski
reviewed
Oct 29, 2026
dougszumski
left a comment
dougszumski
left a comment
Member
There was a problem hiding this comment.
Do we need to add thermal_subsystem to https://github.com/stackhpc/redfish_exporter/blob/thermal-subsystem-fans/collector/chassis/collector.go#L111?
MurrayGroves
force-pushed
the
thermal-subsystem-fans
branch
from
October 29, 2026 16:45
2af2ec1 to
83f44e6
Compare
Author
Oops, yes. Added now. |
dougszumski
approved these changes
Oct 29, 2026
MurrayGroves
force-pushed
the
thermal-subsystem-fans
branch
from
October 30, 2026 09:42
83f44e6 to
93f66ab
Compare
MurrayGroves
force-pushed
the
thermal-subsystem-fans
branch
from
October 30, 2026 10:04
93f66ab to
627d431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that ThermalSubsystem fan readings don't include thresholds, so these aren't reported.