Add neutron.yml to baremetal env - #2527
claudia-lola wants to merge 3 commits into
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 SummaryAdds a baremetal Neutron configuration that sets WalkthroughThe bare-metal Neutron configuration now enables the ChangesNeutron configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🟡 Moderate · up to The new baremetal Neutron driver list places genericswitch before ovn, which can cause incorrect port-binding behavior. Reorder the drivers to place ovn before genericswitch before merging. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 66b454bc-9749-4330-b9c6-60961f36da87
📒 Files selected for processing (1)
etc/kayobe/environments/baremetal/neutron.yml
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (5)
- GitHub Check: stackhpc/check
- GitHub Check: Ansible 2.19 lint with Python 3.12
- GitHub Check: Ansible 2.20 lint with Python 3.12
- GitHub Check: Tox docs with Python 3.12
- GitHub Check: Tox releasenotes with Python 3.12
🔇 Additional comments (1)
etc/kayobe/environments/baremetal/neutron.yml (1)
1-6: LGTM!
|
I think my main problem with all this, is that management of such overrides currently in Kayobe brings in a lot of complications (as in we don't merge these lists between each other - just the last one wins). |
oneswig
left a comment
There was a problem hiding this comment.
Subject to the CodeRabbit comment about list ordering, and noting the wider discussion on why there wasn't a default, and how to work with multiple instantiations from different environments.
2973f9e
Running
kayobe overcloud service deployto addbaremetalmixin would get error:Due to
kolla_neutron_ml2_mechanism_driversbeing undefined.This PR adds defaults for
kolla_neutron_ml2_mechanism_driversin thebaremetalenv.When added
service deployruns without error.