Skip to content

Disable l2vni trunk reconciliation - #2577

Merged
priteau merged 2 commits into
stackhpc/2026.1from
bugfix/l2vni-trunk
Sep 10, 2026
Merged

priteau merged 2 commits into
stackhpc/2026.1from
bugfix/l2vni-trunk

Conversation

@TBExtent

@TBExtent TBExtent commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

L2VNI trunk reconciliation was added to ironic neutron agent in gazpacho, and enabled by default. It assumes that neutron trunk and segment are enabled, which is not guaranteed, so it is safest if it is disabled by default instead.
See this patch: https://review.opendev.org/c/openstack/networking-baremetal/+/974619

@TBExtent
TBExtent requested a review from a team as a code owner September 3, 2026 15:23
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8a9cb699-4edb-4c6c-941e-5ede933fc2b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 6424180c-8551-40c0-b686-9da38f4019bc

📥 Commits

Reviewing files that changed from the base of the PR and between a4e5b48 and 69e9e7b.

📒 Files selected for processing (1)
  • etc/kayobe/environments/baremetal/kolla/config/neutron/ironic_neutron_agent.ini

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: Ansible 2.20 lint with Python 3.12
  • GitHub Check: Ansible 2.19 lint with Python 3.12
🔇 Additional comments (1)
etc/kayobe/environments/baremetal/kolla/config/neutron/ironic_neutron_agent.ini (1)

1-5: LGTM!


📝 Summary

Add conditional Ironic Neutron agent configuration that disables L2VNI trunk reconciliation and its event handling when the agent is enabled.

Walkthrough

The change adds a conditional Neutron agent configuration. When the Ironic Neutron agent is enabled, it disables L2 VNI trunk reconciliation and its events.

Changes

Ironic Neutron agent configuration

Layer / File(s) Summary
Disable L2 VNI reconciliation
etc/kayobe/environments/baremetal/kolla/config/neutron/ironic_neutron_agent.ini
Adds an [l2vni] section. Both reconciliation settings are set to False when kolla_enable_ironic_neutron_agent is enabled.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 69e9e

When enabled, the Ironic Neutron agent will no longer perform L2 VNI trunk reconciliation or emit its reconciliation events. The configuration is limited to the intended agent and is ready to merge.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@priteau priteau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include more details on why this is necessary? Is there an upstream bug open (if this is a bug) or a configuration guide that we can link to?

@github-actions github-actions Bot added waiting-author-response PR is waiting for the author to respond and removed waiting-review PR is waiting for a review labels Sep 3, 2026

@priteau priteau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, you can link to this change in the commit: https://review.opendev.org/c/openstack/networking-baremetal/+/974619

L2VNI trunk reconciliation was added to ironic neutron agent in
gazpacho, and enabled by default. It assumes that neutron trunk
and segment are enabled, which is not guaranteed, so it is safest
if it is disabled by default instead.
See this patch:
https://review.opendev.org/c/openstack/networking-baremetal/+/974619
@TBExtent

TBExtent commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Done :)

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Happy Friday @TBExtent, this is a friendly reminder that this PR is waiting for your changes or response. Please take a look when you have a moment!

Note: Once your changes are ready, remove the waiting-author-response label and add the waiting-review label.

@TBExtent TBExtent removed the waiting-author-response PR is waiting for the author to respond label Sep 4, 2026
@TBExtent TBExtent added the waiting-review PR is waiting for a review label Sep 4, 2026
Comment thread etc/kayobe/environments/baremetal/kolla/config/neutron/ironic_neutron_agent.ini Outdated
@github-actions github-actions Bot added waiting-author-response PR is waiting for the author to respond and removed waiting-review PR is waiting for a review labels Sep 9, 2026
@priteau
priteau merged commit 6a4d547 into stackhpc/2026.1 Sep 10, 2026
28 checks passed
@priteau
priteau deleted the bugfix/l2vni-trunk branch September 10, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants