Disable l2vni trunk reconciliation - #2577
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🔇 Additional comments (1)
📝 SummaryAdd conditional Ironic Neutron agent configuration that disables L2VNI trunk reconciliation and its event handling when the agent is enabled. WalkthroughThe change adds a conditional Neutron agent configuration. When the Ironic Neutron agent is enabled, it disables L2 VNI trunk reconciliation and its events. ChangesIronic Neutron agent configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to When enabled, the Ironic Neutron agent will no longer perform L2 VNI trunk reconciliation or emit its reconciliation events. The configuration is limited to the intended agent and is ready to merge. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
priteau
left a comment
There was a problem hiding this comment.
Can you include more details on why this is necessary? Is there an upstream bug open (if this is a bug) or a configuration guide that we can link to?
There was a problem hiding this comment.
For example, you can link to this change in the commit: https://review.opendev.org/c/openstack/networking-baremetal/+/974619
69e9e7b to
df07977
Compare
L2VNI trunk reconciliation was added to ironic neutron agent in gazpacho, and enabled by default. It assumes that neutron trunk and segment are enabled, which is not guaranteed, so it is safest if it is disabled by default instead. See this patch: https://review.opendev.org/c/openstack/networking-baremetal/+/974619
df07977 to
1ce5f04
Compare
|
Done :) |
|
Happy Friday @TBExtent, this is a friendly reminder that this PR is waiting for your changes or response. Please take a look when you have a moment! Note: Once your changes are ready, remove the |
L2VNI trunk reconciliation was added to ironic neutron agent in gazpacho, and enabled by default. It assumes that neutron trunk and segment are enabled, which is not guaranteed, so it is safest if it is disabled by default instead.
See this patch: https://review.opendev.org/c/openstack/networking-baremetal/+/974619