Skip to content

2026.1 - Host images - #2589

Merged
owenjones merged 2 commits into
stackhpc/2026.1from
2026.1/host-image-acl
Sep 9, 2026
Merged

owenjones merged 2 commits into
stackhpc/2026.1from
2026.1/host-image-acl

Conversation

@owenjones

@owenjones owenjones commented Sep 8, 2026

Copy link
Copy Markdown
Member
  • The acl package is now included in host image builds, this is required for bootstrapping on some systems
  • New host images have been built for 2026.1

@owenjones
owenjones requested a review from a team as a code owner September 8, 2026 11:44
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Sep 8, 2026
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d9611a0d-d6ae-4bc6-bca8-7709765c483a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Summary

Adds the acl package to Rocky-based overcloud host image builds. This supports bootstrapping on systems that require ACL functionality.

Walkthrough

The overcloud DIB configuration now includes acl for Rocky images. A release note documents this package requirement for Rocky host image bootstrapping.

Changes

Rocky image package update

Layer / File(s) Summary
Configure and document the ACL package
etc/kayobe/stackhpc-overcloud-dib.yml, releasenotes/notes/...
The image build adds acl when os_distribution is rocky. The release note documents the Rocky host image change.

Priority: ⬇️ Low — Impact reflects low issue severity.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Severity of issue fixed: Low

Merge Risk: 🔵 Low · up to a4d73

Rocky host images will include the acl package to support bootstrapping. The remaining merge-readiness risk is limited to correcting the release note wording.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 11c74f58-8133-44b9-b9de-3919df8d21df

📥 Commits

Reviewing files that changed from the base of the PR and between 18a3cf0 and a4d737a.

📒 Files selected for processing (2)
  • etc/kayobe/stackhpc-overcloud-dib.yml
  • releasenotes/notes/host-image-acl-4aad7ee0a83c0375.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: Ansible 2.20 lint with Python 3.12
  • GitHub Check: Ansible 2.19 lint with Python 3.12
🔇 Additional comments (1)
etc/kayobe/stackhpc-overcloud-dib.yml (1)

99-99: LGTM!

Comment thread releasenotes/notes/host-image-acl-4aad7ee0a83c0375.yaml Outdated
@owenjones
owenjones marked this pull request as draft September 8, 2026 11:55
@owenjones owenjones changed the title Include acl package in Rocky host images Include acl package in host images Sep 8, 2026
@owenjones
owenjones force-pushed the 2026.1/host-image-acl branch from a4d737a to 90d677c Compare September 8, 2026 11:56
@owenjones owenjones changed the title Include acl package in host images 2026.1 - Host images Sep 8, 2026
@owenjones
owenjones marked this pull request as ready for review September 8, 2026 13:10

@Alex-Welsh Alex-Welsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if CI passes

The `acl` package is now included in Rocky host image builds,
this is required for bootstapping on some systems.
New host images have been built for the 2026.1 (Gazpacho) release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants