add override section to upgrade doc - #2594
Conversation
📝 SummaryAdds an upgrade guide warning for custom service map overrides. It instructs users to synchronise WalkthroughThe upgrade guide now warns users with custom service map overrides to synchronise them with Kayobe upstream. It provides ChangesUpgrade guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🟡 Moderate · up to The upgrade guide can direct operators to compare the wrong release or an unavailable local path, allowing service-map changes to be missed during upgrades. Update the commands before merging. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: bd06c1d5-c0b3-4e92-9bb4-1aa965d57629
📒 Files selected for processing (1)
doc/source/operations/upgrading-openstack.rst
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: stackhpc/check
- GitHub Check: Ansible 2.19 lint with Python 3.12
- GitHub Check: Ansible 2.20 lint with Python 3.12
- GitHub Check: Tox docs with Python 3.12
| git clone https://github.com/stackhpc/kayobe -b stackhpc/2025.1 | ||
| cd kayobe/ansible/roles/kolla-ansible/templates/ | ||
| sdiff -w 200 overcloud-services.j2 /home/stack/2025.1-upgrade/src/kayobe-config/etc/kayobe/kolla/inventory/overcloud-services.j2 | ||
| sdiff -w 200 overcloud-components.j2 /home/stack/2025.1-upgrade/src/kayobe-config/etc/kayobe/kolla/inventory/overcloud-components.j2 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use the target release and the active configuration path.
This guide targets the 2026.1 upgrade, but the commands clone stackhpc/2025.1 and compare against /home/stack/2025.1-upgrade/.... The 2025.1 and 2026.1 upstream templates already differ, so this comparison can miss mappings required by the target release. (raw.githubusercontent.com)
The absolute path also fails when the deployment uses another checkout location. Use the release substitution used elsewhere in this guide, enable :substitutions: for this code block, and use $KAYOBE_CONFIG_PATH and $KAYOBE_ENVIRONMENT for the local files. This keeps the comparison aligned with the overcloud-services.j2 input loaded by kolla.yml.
Suggested update
.. code-block:: console
+ :substitutions:
- git clone https://github.com/stackhpc/kayobe -b stackhpc/2025.1
+ git clone https://github.com/stackhpc/kayobe -b stackhpc/|current_release_git_branch_name|
cd kayobe/ansible/roles/kolla-ansible/templates/
- sdiff -w 200 overcloud-services.j2 /home/stack/2025.1-upgrade/src/kayobe-config/etc/kayobe/kolla/inventory/overcloud-services.j2
- sdiff -w 200 overcloud-components.j2 /home/stack/2025.1-upgrade/src/kayobe-config/etc/kayobe/kolla/inventory/overcloud-components.j2
+ sdiff -w 200 overcloud-services.j2 "$KAYOBE_CONFIG_PATH"/kolla/inventory/overcloud-services.j2
+ sdiff -w 200 overcloud-components.j2 "$KAYOBE_CONFIG_PATH"/kolla/inventory/overcloud-components.j2
- sdiff -w 200 overcloud-services.j2 /home/stack/2025.1-upgrade/src/kayobe-config/etc/kayobe/environments/<env>/kolla/inventory/overcloud-services.j2
- sdiff -w 200 overcloud-components.j2 /home/stack/2025.1-upgrade/src/kayobe-config/etc/kayobe/environments/<env>/kolla/inventory/overcloud-components.j2
+ sdiff -w 200 overcloud-services.j2 "$KAYOBE_CONFIG_PATH"/environments/"$KAYOBE_ENVIRONMENT"/kolla/inventory/overcloud-services.j2
+ sdiff -w 200 overcloud-components.j2 "$KAYOBE_CONFIG_PATH"/environments/"$KAYOBE_ENVIRONMENT"/kolla/inventory/overcloud-components.j2Also applies to: 978-979
Source: MCP tools
No description provided.