Skip to content

basic alerts for proxySQL - #2597

Open
CloudyBug wants to merge 2 commits into
stackhpc/2026.1from
feat-ProxySQL-Alerts
Open

CloudyBug wants to merge 2 commits into
stackhpc/2026.1from
feat-ProxySQL-Alerts

Conversation

@CloudyBug

Copy link
Copy Markdown
Contributor

No description provided.

@CloudyBug CloudyBug self-assigned this Sep 14, 2026
@CloudyBug CloudyBug added the monitoring All things related to observability & telemetry label Sep 14, 2026
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Sep 14, 2026
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4819d083-2521-429c-97fe-e7bfdeafc57d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Summary

Adds nine Prometheus alert rules for ProxySQL. The rules detect authentication failures, SQL injection, connection limits, MySQL errors, slow queries, shunned nodes, ProxySQL restarts, and service downtime. Each alert defines severity and operational annotations.

Walkthrough

The change adds a Prometheus rules file with nine ProxySQL alerts. The alerts cover authentication errors, SQL injection, connection limits, MySQL errors, slow queries, shunned nodes, restarts, and downtime.

Changes

ProxySQL monitoring

Layer / File(s) Summary
ProxySQL alert rules
etc/kayobe/kolla/config/prometheus/proxysql.rules
Adds nine Prometheus alert rules with expressions, severity labels, and summary and description annotations. Jinja2 raw tags preserve the alert expressions.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🟡 Moderate · up to a83de

ProxySQL alerts may not load due to invalid YAML, leaving the newly monitored conditions without alerts. Fix the syntax before merge.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b01fa3c9-0fbf-48f8-8d40-891b577832f8

📥 Commits

Reviewing files that changed from the base of the PR and between 362c4cf and a83dee5.

📒 Files selected for processing (1)
  • etc/kayobe/kolla/config/prometheus/proxysql.rules

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: stackhpc/check
  • GitHub Check: Ansible 2.20 lint with Python 3.12
  • GitHub Check: Ansible 2.19 lint with Python 3.12
🔇 Additional comments (1)
etc/kayobe/kolla/config/prometheus/proxysql.rules (1)

45-45: 🎯 Functional Correctness

mysql_error_total is a ProxySQL built-in exporter metric. The standard mysqld_exporter used by the repository's mysqld scrape job does not expose this metric. The unscoped expression therefore does not combine standard MySQL exporter errors with ProxySQL errors, so a job selector is not required for this concern.

Comment thread etc/kayobe/kolla/config/prometheus/proxysql.rules Outdated
Comment thread etc/kayobe/kolla/config/prometheus/proxysql.rules Outdated
@CloudyBug

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@priteau priteau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CloudyBug
CloudyBug marked this pull request as ready for review September 15, 2026 10:00
@CloudyBug
CloudyBug requested a review from a team as a code owner September 15, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

monitoring All things related to observability & telemetry waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants