feat(automation): onboard automation templates list datasource - #1729
Open
SerseusWasTaken wants to merge 2 commits into
Open
feat(automation): onboard automation templates list datasource#1729SerseusWasTaken wants to merge 2 commits into
SerseusWasTaken wants to merge 2 commits into
Conversation
SerseusWasTaken
force-pushed
the
feat/volume-automation-list-templates
branch
3 times, most recently
from
September 1, 2026 10:54
448ccba to
bfad50a
Compare
Relates to STACKITTPR-790
SerseusWasTaken
force-pushed
the
feat/volume-automation-list-templates
branch
from
September 1, 2026 10:57
bfad50a to
9703c1a
Compare
SerseusWasTaken
marked this pull request as ready for review
September 1, 2026 11:10
| Region: types.StringValue("eu01"), | ||
| }, | ||
| valid: false, | ||
| }, |
Contributor
There was a problem hiding this comment.
these 2 tests are a bit contradictory. From paginate.All:
var items []Item
for item, err := range Items(request, opts...) {
if err != nil {
return items, err
}
items = append(items, item)
}
return items, nilSo an empty, non-nil list would never be returned.
I'd suggest to change the implementation to accept nil slices. From a glance it looks like this would be safe. slices.SortFunc does not panic on a nil slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relates to STACKITTPR-790
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)