Skip to content

feat(automation): onboard automation templates list datasource - #1729

Open
SerseusWasTaken wants to merge 2 commits into
mainfrom
feat/volume-automation-list-templates
Open

feat(automation): onboard automation templates list datasource#1729
SerseusWasTaken wants to merge 2 commits into
mainfrom
feat/volume-automation-list-templates

Conversation

@SerseusWasTaken

Copy link
Copy Markdown
Contributor

Description

Relates to STACKITTPR-790

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@SerseusWasTaken
SerseusWasTaken force-pushed the feat/volume-automation-list-templates branch 3 times, most recently from 448ccba to bfad50a Compare September 1, 2026 10:54
@SerseusWasTaken
SerseusWasTaken force-pushed the feat/volume-automation-list-templates branch from bfad50a to 9703c1a Compare September 1, 2026 10:57
@SerseusWasTaken
SerseusWasTaken marked this pull request as ready for review September 1, 2026 11:10
@SerseusWasTaken
SerseusWasTaken requested a review from a team as a code owner September 1, 2026 11:10
Region: types.StringValue("eu01"),
},
valid: false,
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 2 tests are a bit contradictory. From paginate.All:

	var items []Item
	for item, err := range Items(request, opts...) {
		if err != nil {
			return items, err
		}
		items = append(items, item)
	}
	return items, nil

So an empty, non-nil list would never be returned.

I'd suggest to change the implementation to accept nil slices. From a glance it looks like this would be safe. slices.SortFunc does not panic on a nil slice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants