Skip to content

[DNM] chore: expose more falco metrics - #3965

Draft
Molter73 wants to merge 1 commit into
release-3.25from
mauro/chore/expose-more-falco-metrics-3.25
Draft

[DNM] chore: expose more falco metrics#3965
Molter73 wants to merge 1 commit into
release-3.25from
mauro/chore/expose-more-falco-metrics-3.25

Conversation

@Molter73

Copy link
Copy Markdown
Member

This is a simple patch that exposes more internal falco metrics through our prometheus endpoint.

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

This is a simple patch that exposes more internal falco metrics through
our prometheus endpoint.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.14%. Comparing base (ac7740c) to head (941f513).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
collector/lib/CollectorStatsExporter.cpp 0.00% 26 Missing ⚠️
collector/lib/system-inspector/Service.cpp 0.00% 13 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-3.25    #3965      +/-   ##
================================================
- Coverage         27.34%   27.14%   -0.20%     
================================================
  Files                95       95              
  Lines              5420     5459      +39     
  Branches           2545     2571      +26     
================================================
  Hits               1482     1482              
- Misses             3211     3250      +39     
  Partials            727      727              
Flag Coverage Δ
collector-unit-tests 27.14% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants