Aligned normal_lccdf and std_normal_lccdf with the lcdf functions - #3363
Open
jaburgoyne wants to merge 1 commit into
Open
Aligned normal_lccdf and std_normal_lccdf with the lcdf functions#3363jaburgoyne wants to merge 1 commit into
jaburgoyne wants to merge 1 commit into
Conversation
Collaborator
|
Fyi our backend CI is migrating to a new server cluster so the jenkins will hiccup for a minute while we get everything settled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses #1985 by updating
normal_lccdfandstd_normal_lccdfto callnormal_lcdfandstd_normal_lcdfwith the signs ofxandmureversed.Tests
The tests have been updated to use the latest values of
pnormin R 4.6.1. These are more direct tests than the previous versions, which worked via anexpcall, somewhat defeating the purpose of having separatelcdfandlccdffunctions.Side Effects
None.
Release notes
normal_lccdfandstd_normal_lccdfupdated to usenormal_lcdfandstd_normal_lcdfimplementationsChecklist
Copyright holder: John Ashley Burgoyne
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested