Repository navigation
Conversation
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
amorton
requested changes
Jun 18, 2026
Contributor
There was a problem hiding this comment.
-1 Blocking this merging.
There are two possible fixes here: either the API support flag is wrong (we dont support it) OR we actually should support it and the bug is that we dont.
we need to decide on what we want to do before letting AI write code. Also, PR comments such as these are not very helpful it is just a mash of words
amorton
reviewed
Jun 18, 2026
Contributor
|
There is an existing test the confirms some code things we should not be able to filter on a counter BUT checking the design docs we said it was possible to filter on a counter. we need to work out what is the correct behaviour |
Contributor
Author
|
Good point @amorton, digging into this in more detail (i.e., whether there's a technical reason why we don't support it, and if so, can we overcome that and support it, as the spec indicates that we want to do) |
erichare
changed the title
erichare
force-pushed
the
fix/counter-filter-apisupport-2462
branch
from
June 22, 2026 14:50
db7843d to
f06232c
Compare
erichare
force-pushed
the
fix/counter-filter-apisupport-2462
branch
from
June 22, 2026 14:57
f06232c to
3603a16
Compare
A table with a counter column was described with apiSupport.filter:true, but filtering on a counter actually failed at runtime with INVALID_FILTER_COLUMN_VALUES. The describe output was correct — counters ARE filterable in CQL via ALLOW FILTERING (they just cannot be indexed) — the gap was a missing JSON->CQL codec. Filter literals arrive as BigDecimal/BigInteger, but COUNTER only registered COUNTER_FROM_LONG, so codec lookup threw ToCQLCodecException. Add COUNTER_FROM_BIG_DECIMAL and COUNTER_FROM_BIG_INTEGER (mirroring BIGINT's longValueExact variants) and register them. With the codecs in place, WhereCQLClauseAnalyzer proceeds with ALLOW FILTERING and emits a MISSING_INDEX warning, so apiSupport.filter stays true. This reverses the earlier flip-to-false approach: keep filter=true and make the runtime match it. insert/update remain unsupported (insert=false / Update.NONE), and isUnsupportedDML() is unchanged (already true via insert=false). Tests: - JSONCodecRegistryTest: add COUNTER cases for Long/BigInteger/BigDecimal -> Long binding. - UnsupportedTypeTableIntegrationTest.Counter: assert describe reports filter:true; rewrite filterCounter to seed a counter via raw CQL and expect the row back with a MISSING_INDEX warning.
erichare
force-pushed
the
fix/counter-filter-apisupport-2462
branch
from
June 22, 2026 15:01
3603a16 to
fbeb50c
Compare
Contributor
Author
|
@amorton Updated the PR based on our investigation last week! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds
BigDecimalandBigIntegercounter codecs so JSON numeric filter values convert to CQL counter values. Adds regression coverage for successful counter filtering, exact numeric conversion, overflow, and non-integral input.Which issue(s) this PR fixes:
Fixes #2462
Verification:
./mvnw test -Dtest=JSONCodecRegistryTest— 170 tests, 0 failures, 0 errors, 0 skipped; formatting checks passed.Not rerun:
UnsupportedTypeTableIntegrationTest, the full unit suite, or integration suites.Checklist