Repository navigation
Conversation
RED: all 16 key-presence combinations fail to throw JsonMappingException in FindAndRerankSortClauseDeserializerTest on Java 21.
GREEN: 96 parser, reranking builder, and ObjectMapper tests pass on Java 21, including all 16 conflicting-key cases.
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
4 tasks done
Contributor
Author
|
@Hazel-Datastax @amorton when you get a chance do you mind taking a look at this |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Rejects
$hybridsorts that contain both$vectorand$vectorize, using key presence before either value is interpreted. Adds coverage for valid, null, empty, and whitespace values.Which issue(s) this PR fixes:
Fixes #2616
Verification:
./mvnw -Dtest=FindAndRerankSortClauseDeserializerTest test— 41 tests passed, 0 failures, 0 errors, 0 skipped. Full unit and integration suites were not run.Checklist