Repository navigation
Conversation
Confirmed RED on main: all nine new malformed binary cases fail, while the 25 existing deserializer cases pass.
Confirmed GREEN: 44 parser and HTTP regression tests pass. Malformed binary values now return REQUEST_STRUCTURE_MISMATCH with the binary field path, and valid binary vectors still decode.
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Validates
findAndRerankhybrid-sort$binaryvectors during parsing. Malformed Base64, invalid byte lengths, empty vectors, and non-string payloads now returnREQUEST_STRUCTURE_MISMATCHerrors identifyingsort.$hybrid.$vector.$binary. Valid binary vectors and explicit$vector: nullretain their existing behavior.Which issue(s) this PR fixes:
Fixes #2609
Verification
./mvnw -Dtest=FindAndRerankSortClauseDeserializerTest,FindAndRerankBinaryVectorTest test— 44 tests run, 0 failures, 0 errors, 0 skipped;BUILD SUCCESS. Full unit and integration suites were not run.Checklist