Repository navigation
Conversation
TestConstants reset the TenantFactory singleton and initialized it as ASTRA every time it was built. A QuarkusTest shares that singleton with the running app, which initializes it from config as CASSANDRA, so any later MCP tools/call on the same profile failed tenant resolution. Initialize the factory only when nothing has, and build TENANT directly with Tenant.create. Add a raw tools/call check to McpProtocolTest that builds TestConstants first and expects MCP_FEATURE_NOT_ENABLED.
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
TestConstantsno longer resets the sharedTenantFactoryto ASTRA. It initializes the factory only when unset and builds its ASTRA tenant directly, preserving the app's tenant mode in a@QuarkusTest. A newMcpProtocolTestcase covers a rawtools/callafter constructingTestConstants.Which issue(s) this PR fixes:
No issue filed. Found while working on #2625.
Verification
Focused local test passed with 2 tests, 0 failures, 0 errors, and 0 skipped:
Current GitHub checks pass for unit tests and both DSE and HCD integration tests. No full unit suite or local integration suite was rerun for this cleanup.
Checklist