Repository navigation
Conversation
Run the SonarScanner for Maven on pushes to main and on pull requests against main, using the IBM SonarQube org secrets. Analysis scope lives in sonar.* properties in pom.xml. Coverage comes from the unit test JaCoCo report.
Contributor
➡️ Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
The IBM_SONARQUBE_CERT_PASSWORD org secret ends in whitespace. Passed through quoted, it made the scanner reject the truststore with "PKCS12 key store mac invalid". Strip leading and trailing whitespace first.
|
Contributor
➡️ Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
➡️ Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds an
IBM SonarQube Scanworkflow that runs the unit tests, then the SonarScanner for Maven, using the existingIBM_SONARQUBE_*org secrets. Pushes tomainget a branch analysis. Pull requests againstmainget a PR analysis that waits on the quality gate. Fork PRs are skipped because they get no secrets. Analysis scope lives insonar.*properties inpom.xml, since the Maven scanner ignoressonar-project.properties. Coverage is unit tests only. The truststore password secret has trailing whitespace, so the workflow trims it.Which issue(s) this PR fixes:
Fixes #2664
Verification
A scan against a local SonarQube container indexed 820 main files, imported unit coverage at 52.3%, and passed the default gate. The full unit suite passed with 3616 tests and no failures.
actionlintis clean.The IBM server itself is only tested by this PR's run. Open questions: does project
544478-564388942need to exist on the server first, and should this check be required onmain?Checklist