[6.x] Multisite - entry grouping - #15241
Open
jaygeorge wants to merge 33 commits into
Open
Conversation
Delete-group meta Removing a group now copies each row’s grid meta into Other (same path as drag) and drops the old drop zone. Slug-key collisions Named groups store a stable group_handle in sites.yaml. Reload uses that id instead of re-slugging the title, so “New York” / “new york”, “Café” / “Cafe”, and a group titled “Other” stay separate from the pinned Other section. New groups also refuse the reserved other key. Empty-sites errors If every site is removed, the required error is attached to the group grids that were actually submitted, not always group_other_sites.
…ight to the "add group" stack
…ew Group. Saving the title still keeps the group. Leaving edit mode (Discard/Cancel) does not try to delete it again, since that path already restores or remounts the form.
Reuse the shared Combobox for type-to-filter, and disable virtualization when options have variable-height group headers.
Update the trigger immediately on select and keep an Other prefix so the chevron layout does not jump while the localization loads.
…how many items there is to choose from when scrollbars disappear like on macOS
When a second localization in a group is created, the origin switches to the first localization in the group. If the group has none yet, keep the current active/root behaviour.
Otherwise a remaining in-group localization gets the Origin badge and becomes the default, which is misleading.
…oned grids, not every Grid in the CP. For grids in the cp, people may want to add a few rows at once so auto focusing on the row might be annoying
Clear a stale Working In selection when a switch is aborted, restore site group sections on Discard Changes, and tighten related grouping edge cases with tests.
| if (!from) return from; | ||
|
|
||
| return data_get(this.publishContainer?.values, key); | ||
| const prefix = this.config.prefix_from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
For multisite installs, sites display as a flat list everywhere (site configuration, entries, site pickers, etc.).
Larger sites could have multiple locations and related locales (e.g.
Paris > French,Paris > English, and thenMontreal > French,Montreal > English).In a flat list there’s no way to express that hierarchy, so related sites are hard to understand and manage.
What this PR Does
Englishsite in the group "Paris" will have its handle automatically be prefixed likeparis_englishComboboxes for localization now have groups
Adjusts the way
Originworks for groupingFixes Multi-Site groups ideas#17
How to Reproduce
Create a localization into a group that already has a site — Origin should default to that group’s origin (and still follow it if that origin later moves out of the group).