Conversation
sipma
approved these changes
Oct 1, 2026
sipma
left a comment
sipma
left a comment
Contributor
There was a problem hiding this comment.
Ignoring the excluded functions when functions are also included was originally intended, because it seemed contradictory to both include and exclude functions, since the same function would have to be both included and excluded for this to have any effect.
With the addition of the --fn_include_callees option, however, there could be functions that were not explicitly included that one may want to exclude, so it makes sense to also act upon the excluded functions in this case.
Thank you for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.