chore: add keywords - #14379
Merged
Merged
Conversation
Add the `stdmath`, `mathematics`, and `math` keywords, carried by 15 of 19 `blas/ext` members (79%) and by the generic base analog `blas/ext/base/gfind-index`. The package previously mirrored the typed-kernel keyword template (`dindex-of`/`sindex-of`), which drops the namespace-level math category tags that generic packages carry.
Add the `stdmath`, `mathematics`, and `math` keywords, carried by 15 of 19 `blas/ext` members (79%) and by the generic base analog `blas/ext/base/gfind-last-index`. The package previously mirrored the typed-kernel keyword template (`dindex-of`/`sindex-of`), which drops the namespace-level math category tags that generic packages carry.
Add the `stdmath`, `mathematics`, and `math` keywords, carried by 15 of 19 `blas/ext` members (79%) and by the generic base analog `blas/ext/base/gindex-of`. The package previously mirrored the typed-kernel keyword template (`dindex-of`/`sindex-of`), which drops the namespace-level math category tags that generic packages carry.
Add the `stdmath`, `mathematics`, and `math` keywords, carried by 15 of 19 `blas/ext` members (79%) and by the generic base analog `blas/ext/base/glast-index-of`. The package previously mirrored the typed-kernel keyword template (`dindex-of`/`sindex-of`), which drops the namespace-level math category tags that generic packages carry.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 19, 2026
blas/ext search packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the namespace-standard
stdmath,mathematics, andmathkeywords to the fourblas/extsearch packages that omit them, bringing theirpackage.jsonkeyword sets in line with their siblings and their generic base analogs.Namespace summary
@stdlib/blas/extbasenamespace aggregator).package.jsonshape (scripts/stdlib/manifestkey sets), README section order, test/benchmark/example file naming, and keyword sets.package.jsonkeywords— the set {stdmath,mathematics,math} is carried by 15/19 members (79%), including every non-search operation (join,circshift,copy-within,one-to,zero-to,unitspace, ...) and thebaseaggregator.assignAPI variant (13/18 function packages, 72%), stats keywords (8/18), and the per-function signature/validation shapes (the operations are semantically heterogeneous). Error construction is already uniformlyformatacross the namespace, so there is no drift to normalize.Per outlier package
blas/ext/find-indexCarried the typed-kernel keyword template (
stdlib,blas,find, ...) rather than the template of its true structural analog, the genericblas/ext/base/gfind-index. Addedstdmath,mathematics, andmathimmediately afterstdlib, matching the ordering used by every sibling that carries them. Conformance: 15/19 (79%).blas/ext/find-last-indexSame typed-template copy-drift; the generic analog
blas/ext/base/gfind-last-indexcarries the three keywords, as do all non-search siblings. Added the keywords in sibling-consistent order. Conformance: 15/19 (79%).blas/ext/index-ofKeyword set mirrored the typed
dindex-of/sindex-ofkernels, which drop the broad math-category tags in favor of dtype tags; the generic analogblas/ext/base/gindex-ofretains them. Addedstdmath,mathematics, andmath. Conformance: 15/19 (79%).blas/ext/last-index-ofLongest deviating keyword array in the group, but math tags were absent for the same reason;
blas/ext/base/glast-index-ofcarries them. Added the keywords afterstdlib. Conformance: 15/19 (79%).Related Issues
No.
Questions
No.
Other
Validation
Structural features were extracted from the filesystem and from
package.json/README strings; semantic features (public signature, return kind, validation prologue, error construction, JSDoc shape, dependencies) were extracted per package. The single surviving drift finding — the missing math keywords on the four generic search packages — was confirmed by a three-agent validation panel (semantic review, cross-reference against tests/examples/docs, and structural review); all three returnedconfirmed-driftfor all four packages. Cross-referencing found no test, example, REPL doc, TypeScript test, or documented API contract that relies on the current keyword sets, and the change is metadata-only: no observable behavior, signature, or test expectation changes.Deliberately excluded from this PR:
basenamespace aggregator — a different kind of package that legitimately omits theNotesREADME section and the__stdlib__marker.assign-variant files — present in only 13/18 function packages, reflecting an intentional API distinction (not every operation exposes an in-place output variant) rather than drift.lib/base.jsinsum,to-sorted, andto-sortedhp— correcting it is a refactor that would cascade into logic and tests, which is out of scope for a drift correction.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored end-to-end by Claude Code as part of a scheduled cross-package API drift-detection routine over
@stdlib/blas/ext. Structural and semantic features were extracted from all 19 namespace members, a majority vote (≥75%) surfaced the missing math keywords on the four generic search packages, and a three-agent validation panel confirmed the drift before the metadata-only fix was applied. Pending human audit (draft).@stdlib-js/reviewers
Generated by Claude Code