chore: clean-up - #14380
Merged
Merged
Conversation
…d/strategy` Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BtNcAgnF5HjEo3yHbDT6EY
…ed1d/unblocked` Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BtNcAgnF5HjEo3yHbDT6EY
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
marked this pull request as ready for review
August 18, 2026 16:26
kgryte
reviewed
Aug 19, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-08-17 15:10 (-0700) (0acfa70d8) and 2026-08-18 04:03 (-0700) (600a127f0).This pull request:
ndarray/base/kernels/generic/unary-strided1d/strategy: Restore "containing methods" dropped from repl.txt in eb27106 so the REPL help text matches README.md, lib/index.js, lib/main.js, and package.json inlib/node_modules/@stdlib/ndarray/base/kernels/generic/unary-strided1d/strategy/docs/repl.txt.ndarray/base/kernels/generic/unary-strided1d/unblocked: Fix formatting inconsistency introduced in 2359f61:lib/node_modules/@stdlib/ndarray/base/kernels/generic/unary-strided1d/unblocked/lib/4d.js:202had( S2*sv[1]), missing the closing-paren space present everywhere else in the file (e.g., line 230) and across the 0d–10d kernels. Pad it to( S2*sv[1] )for consistency.Related Issues
No.
Questions
No.
Other
Validation. All 25 commits merged to
developin the window were reviewed by four independent passes: two style-compliance audits againstdocs/style-guidesand established reference packages (unary-strided1d/blocked,stats/base/ndarray/dnanmin, already-migrated ULP test files), and two bug scans covering the newunary-strided1dkernel packages (dispatch bounds, per-dimension stride/offset arithmetic), thednanmaxC addon (NAPI argument handling, memory management, compile check), the ULP test migrations (assertion targets, leftover requires), and the docs/bot commits. Deliberately excluded: anything requiring interpretation or changes outside the window's diff — notably, thednanmaxC example'sNaNplacement at a buffer index the strided view never visits was left alone, since the file byte-for-byte matches the establisheddnanminreference.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated review of commits merged to
developin the last 24 hours; findings were cross-validated by multiple independent review passes before inclusion.🤖 Generated with Claude Code
https://claude.ai/code/session_01BtNcAgnF5HjEo3yHbDT6EY
Generated by Claude Code