Skip to content

chore: clean-up - #14380

Merged
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-08-18
Aug 19, 2026
Merged

chore: clean-up#14380
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-08-18

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-08-17 15:10 (-0700) (0acfa70d8) and 2026-08-18 04:03 (-0700) (600a127f0).

This pull request:

  • ndarray/base/kernels/generic/unary-strided1d/strategy: Restore "containing methods" dropped from repl.txt in eb27106 so the REPL help text matches README.md, lib/index.js, lib/main.js, and package.json in lib/node_modules/@stdlib/ndarray/base/kernels/generic/unary-strided1d/strategy/docs/repl.txt.
  • ndarray/base/kernels/generic/unary-strided1d/unblocked: Fix formatting inconsistency introduced in 2359f61: lib/node_modules/@stdlib/ndarray/base/kernels/generic/unary-strided1d/unblocked/lib/4d.js:202 had ( S2*sv[1]), missing the closing-paren space present everywhere else in the file (e.g., line 230) and across the 0d–10d kernels. Pad it to ( S2*sv[1] ) for consistency.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 25 commits merged to develop in the window were reviewed by four independent passes: two style-compliance audits against docs/style-guides and established reference packages (unary-strided1d/blocked, stats/base/ndarray/dnanmin, already-migrated ULP test files), and two bug scans covering the new unary-strided1d kernel packages (dispatch bounds, per-dimension stride/offset arithmetic), the dnanmax C addon (NAPI argument handling, memory management, compile check), the ULP test migrations (assertion targets, leftover requires), and the docs/bot commits. Deliberately excluded: anything requiring interpretation or changes outside the window's diff — notably, the dnanmax C example's NaN placement at a buffer index the strided view never visits was left alone, since the file byte-for-byte matches the established dnanmin reference.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of an automated review of commits merged to develop in the last 24 hours; findings were cross-validated by multiple independent review passes before inclusion.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BtNcAgnF5HjEo3yHbDT6EY


Generated by Claude Code

claude added 2 commits August 18, 2026 12:39
…d/strategy`

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BtNcAgnF5HjEo3yHbDT6EY
…ed1d/unblocked`

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BtNcAgnF5HjEo3yHbDT6EY
@stdlib-bot

stdlib-bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/kernels/generic/unary-strided1d/strategy $\\color{red}168/333$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{red}0/7$
$\\color{green}+0.00\\%$
$\\color{red}168/333$
$\\color{green}+0.00\\%$
ndarray/base/kernels/generic/unary-strided1d/unblocked $\\color{red}2035/3351$
$\\color{green}+0.00\\%$
$\\color{green}13/13$
$\\color{green}+0.00\\%$
$\\color{red}0/12$
$\\color{green}+0.00\\%$
$\\color{red}2035/3351$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title fix: follow-up fixes for commits merged to develop (2026-08-18 review) chore: follow-up fixes for commits merged to develop (2026-08-18 review) Aug 18, 2026
@Planeshifter
Planeshifter requested a review from kgryte August 18, 2026 16:26
@Planeshifter
Planeshifter marked this pull request as ready for review August 18, 2026 16:26
@Planeshifter
Planeshifter requested a review from a team August 18, 2026 16:26
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 18, 2026
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte changed the title chore: follow-up fixes for commits merged to develop (2026-08-18 review) chore: clean-up Aug 19, 2026
@kgryte
kgryte merged commit dcb03da into develop Aug 19, 2026
12 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-08-18 branch August 19, 2026 07:15
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants