test: migrate stats/base/dists/geometric/stdev to ULP-based assertions - #14385
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/geometric/stdevfrom relative tolerance assertions to ULP difference assertions, as described in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomputation (previously1.0 * EPS * abs( expected[ i ] )) and the associatedt.ok( delta <= tol, ... )/ exact-equality branch with a singlet.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' )assertion.@stdlib/assert/is-almost-same-valueand removes the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.The same change is applied to both
test/test.jsandtest/test.native.js.ULP bound:
1ULP, for the "the function returns the standard deviation of a geometric distribution" test in bothtest/test.jsandtest/test.native.js. This is the measured minimum over the full fixture set (1000 values,test/fixtures/python/data.json); the observed ULP difference distribution is{0: 717, 1: 283}. Lowering the bound to0causes 283 test cases to fail, so1is the tightest bound which passes. The suite was run twice at the final bound to confirm the result is deterministic.Only the two test files are changed; no source, documentation, or fixture files were touched.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
test/test.native.jsis skipped locally, as the native add-on was not built in this environment. The ULP bound intest/test.native.jsmirrors the bound measured for the JavaScript implementation, consistent with prior conversions in this family (e.g.,stats/base/dists/negative-binomial/cdf,stats/base/dists/frechet/mode). As an additional check, the C implementation (sqrt( 1.0-p ) / p, persrc/main.c) was compiled standalone and evaluated over the full fixture set; its results are bitwise identical to the JavaScript implementation for all 1000 fixture values, so the same bound applies.if ( y === expected[i] )exact-equality fast path was removed, asisAlmostSameValuealready returnstruefor exactly equal values.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, running as an automated task. The ULP bound was determined empirically by measuring the ULP difference across the full fixture set and verifying that the next lower bound fails.
@stdlib-js/reviewers
Generated by Claude Code