test: migrate stats/base/dists/planck/stdev to ULP-based assertions - #14395
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WKbR3GmRrGfST5h1G2dcZe
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
stats/base/dists/planck/stdevfrom EPS-scaled relative tolerance comparisons to ULP-based assertions using@stdlib/assert/is-almost-same-value, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires fromtest/test.jsandtest/test.native.js.Details:
stats/base/dists/planck/stdev(test/test.jsandtest/test.native.js).1in bothtest/test.jsandtest/test.native.js.1is the smallest integer bound under which the full 1000-value fixture set passes for both the JavaScript and C implementations. At0, 273 of the 1000 fixture assertions fail in each file (727 fixture values are bit-for-bit exact), so the bound cannot be tightened further.test/test.native.jsactually executed rather than being skipped. Both runs: 1005 assertions, 1005 passing, in each of the two test files.etc/eslint/.eslintrc.tests.js, and the only changed files are the two test files.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The conversion mirrors the idiom already used in the same family (e.g.,
stats/base/dists/halfnormal/stdev): the fixture loop drops the exact-vs-tolerance branch entirely in favor of a singlet.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' );assertion.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, running unattended as a scheduled task, which selected the package, mirrored the conversion idiom from previously merged conversions, and empirically determined and verified the minimum ULP bound.
@stdlib-js/reviewers
Generated by Claude Code