Skip to content

💻 Convert low-res Soroban fee diagram to Mermaid#2407

Draft
JFWooten4 wants to merge 10 commits into
stellar:mainfrom
JFWooten4:mermaid-2
Draft

💻 Convert low-res Soroban fee diagram to Mermaid#2407
JFWooten4 wants to merge 10 commits into
stellar:mainfrom
JFWooten4:mermaid-2

Conversation

@JFWooten4

Copy link
Copy Markdown
Contributor

Resource fee

The existing diagram isn't bad per se, but it is noticeably underscaled when expanding to wide viewframes. The text just gets huge inside the ref while the page looks minuscule by comparison. And going forward, it's a lot easier for anyone to update a code diagram than recreate the entire image.

@ElliotFriend

Copy link
Copy Markdown
Contributor

Diagram is faithful to the fee model — nice work on this one.

there's a stray todo mermaid ! line (with trailing space) sitting at the tope of the page, which is what's breaking the mdx-format check. Remove that line and this is mergeable.

we might also consider labeling the fixed-component box "non-refundable resource fee" to match the section it links to.

i know this is also marked as a draft. let me know if it's still just a work-in-progress, too.

@JFWooten4

Copy link
Copy Markdown
Contributor Author

All my drafts are WIPs, but I appreciate the feedback and ideas!

They're mostly to let others know what's being worked on, especially if they want to contribute (everything has edits by maintainers).

And yes, some of the old huge bulk ones are being slimmed down through more recent PRs, whereby they are my record of what's still to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants