Deprecate Spanish Crowdin site translations#2410
Merged
Merged
Conversation
ElliotFriend
self-requested a review
May 4, 2026 16:34
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Remove the old announcement bar wrapper and config for translated pages. This was the Google Translate disclaimer that only rendered on `/es` routes. Caveat: the Google Translate navbar control still exists, but this disclaimer no longer displays because the Spanish Docusaurus routes have been removed. Co-authored-by: Codex <noreply@openai.com>
Contributor
Author
|
Slight misnomer in 0f8527b's desc. It was the CROWDIN disclaimer before, and there is now the Google bar on top in the commit. We could add a new disclaimer going forward (the logic still exists here), but since this was the only place it was used, I also dropped the Spanish-specific skeleton |
Contributor
|
we've accrued some conflicts here. can you pull in the changes from |
Closed
Co-authored-by: Codex <noreply@openai.com>
ElliotFriend
added a commit
that referenced
this pull request
Jul 14, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ElliotFriend
approved these changes
Jul 14, 2026
Contributor
There was a problem hiding this comment.
This is amazing!!! Thanks so much for seeing this one through, @JFWooten4!! 🎉
I pushed one commit to add back a script/command in package.json that ships with docusaurus by default. even if we don't use it, it won't harm anything to have the defaults available to us.
Thanks so much!!
Once the build/CI passes, i can get this merged
This was referenced Jul 14, 2026
kaankacar
pushed a commit
that referenced
this pull request
Jul 17, 2026
The i18n/ directory was removed in #2410, so the instruction to ignore it points at nothing. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
ElliotFriend
added a commit
that referenced
this pull request
Jul 17, 2026
* docs: add CONTRIBUTING.md Codify the conventions established during the 2026-07 PR-backlog triage: scope contract for PRs, content/link/metadata conventions, generated-API-page workflow, and the patch/swizzle last-resort ladder. Seeded in part by conventions proposed in #1044. Refs #1044 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Remove baseFee guidance — base fee hasn't changed historically The rationale ("has changed before") was incorrect, so the ruling and its TODO come out rather than getting confirmed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Add i18n scope rule — Spanish translations sunsetting via #2410 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * remove note about `i18n/` directory * docs: clarify _category_.json guidance in CONTRIBUTING Replace the absolute "don't add _category_.json files" rule with the README.mdx-first nuance from the #2617 discussion: prefer README.mdx frontmatter for category metadata, and fall back to _category_.json only for keys it can't express (collapsible/collapsed, description). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in #2404, based on prior discussion at #2233. The Google Translate feature has been working strong for months now, without any build or maintenance burden directly on the content side. Note 1 on my PR and the substance migration in #2409 imply that Bri's on the same side as us in the discussion, so I implemented the clean separation.