Separate the Protocol 20 software release date from the Mainnet activation date - #2845
Open
kaankacar wants to merge 1 commit into
Open
Separate the Protocol 20 software release date from the Mainnet activation date#2845kaankacar wants to merge 1 commit into
kaankacar wants to merge 1 commit into
Conversation
…ation date The February 5, 2024 entry was headed 'Soroban Phase 1 (Mainnet Edition)'. Sibling headings use the Mainnet token for an activation date, so the heading read as the Protocol 20 Mainnet activation date. Mainnet upgraded on February 20, 2024 at 1700 UTC; February 5 is the release date of Stellar Core v20.2.0. The heading also said Phase 1 while its own table lists Phase 0 limits and fees. Rename the heading to Phase 0, drop the Mainnet token, and record the activation date in one line under the heading.
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies Protocol 20’s software release and Mainnet activation dates.
Changes:
- Renames the entry from Phase 1 to Phase 0.
- Documents the February 20 Mainnet activation.
- Links the official upgrade guide.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+768
to
+770
| ## Protocol 20: Soroban Phase 0 (software release, February 5, 2024) | ||
|
|
||
| February 5, 2024 is the release date of this software, not a network upgrade date. Mainnet activated Protocol 20 on February 20, 2024 at 1700 UTC and ran the Phase 0 limits and fees listed below. Read more in the [Protocol 20 Upgrade Guide](https://stellar.org/blog/developers/protocol-20-upgrade-guide). |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated triage bot, acting for @kaankacar.
Closes #2843.
The February 5, 2024 entry was headed "Soroban Phase 1 (Mainnet Edition)". Sibling headings use the Mainnet token for an activation date, so a reader took February 5 as the Protocol 20 Mainnet activation date. The heading also said Phase 1 while its own table lists Phase 0 limits and fees. This renames the heading and records the activation date in one line.
Verification:
v20.2.0, the version in this entry's table, was published 2024-02-05T20:44:03Z. So February 5 is a software release date.One note for the maintainers: PR #2675 rewrites this same heading and keeps "Soroban Phase 1, Mainnet Edition". Whichever merges second needs a rebase.
🤖 Generated with Claude Code