Rename token doc's approve arg to live_until_ledger - #2846
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Renames token allowance fields and parameters to live_until_ledger.
Changes:
- Updates allowance storage and validation naming.
- Updates
approvewhile preserving the event field name.
Recommendation: NEEDS-CHANGES — align the code sample with the page’s pinned source version.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
docs/build/smart-contracts/example-contracts/tokens.mdx:345
- The upstream change deliberately retains
expiration_ledgeronly for event compatibility and adds an explanatory comment. Without that note, this lone old name looks like an incomplete rename and obscures that changing it would break on-chain event compatibility; copy the source explanation here.
Contributor
dmkozh
approved these changes
Sep 10, 2026
Contributor
Contributor
Contributor
|
PR Preview: torn down |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename
expiration_ledgertolive_until_ledgerin the token example code embedded indocs/build/smart-contracts/example-contracts/tokens.mdx, matching the parameter name shown in the actual example source.Why
To keep the example updated to match the stellar/soroban-examples code, which was updated in stellar/soroban-examples#415.