Repository navigation
fix(subagent): deliver background lane results promptly and in full - #233
Merged
Merged
Conversation
added 2 commits
October 10, 2026 12:38
Session 01a123da: four progress-subscribed lanes all finished by 03:37,
yet the parent kept running `sleep 180` until past 04:04, convinced the
lanes were still going.
Progress notices were steered. The steering queue drains one message per
turn by default ("one-at-a-time"), and progress arrives every 15s per
lane, so a minutes-long tool call let dozens queue up. The parent read
one stale progress notice per turn, and the lanes' completion notices
sat behind that backlog. Each steered notice also forced one more model
call after the parent meant to stop, which kept the sleep loop going.
- Send progress and restart notices with triggerTurn: false. They land
as context at the same turn boundary a steer would use, all at once,
without entering the steering queue or forcing an extra model call.
Completion, failure, interrupt, and needs-input keep steer +
triggerTurn.
- Tell the parent, when a lane starts, not to wait with sleep or
polling: end the turn or carry on, since it is woken when the lane
finishes, fails, or needs input. The subscribe description says the
same, except for "none".
- Order the background lane list by creation rather than by which lane
streamed first, as its comment already claimed.
…ification The final notification capped the lane output at 2,000 characters. It is the parent's only copy of the result, since agent_send can reply or stop but not fetch, so a longer report lost its ending (usually the summary) and the parent fell back to parsing the child's session file. Raise the cap to 50,000 characters, the per-task limit a blocking call returns.
Uking-xxx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Background subagents (
run_in_background: true) had three problems getting results back to the parent agent:subscribe: "progress", progress notices went into the steering queue, which hands the parent one message per turn. While the parent sat in a long tool call, progress piled up and the lanes' completion notices waited behind it. The parent never learned the lanes were done.sleeploops. Results were handled only after each sleep ended.Changes
triggerTurn: false, so they land as context at the turn boundary and stay out of the steering queue. Completion, failure, interrupt, and needs-input notices still wake the parent.subscribedescription says the same, except for"none".Testing
main, the completion is missing.pnpm run checkpasses.Not addressed
Progress notices that accumulate while the parent is idle still all enter its context on the next turn. Coalescing them needs a session-layer change.