Skip to content

feat(I3C): adding support for I3C#5

Open
Aymane-ST wants to merge 5 commits into
stm32duino:mainfrom
Aymane-ST:I3C
Open

feat(I3C): adding support for I3C#5
Aymane-ST wants to merge 5 commits into
stm32duino:mainfrom
Aymane-ST:I3C

Conversation

@Aymane-ST

@Aymane-ST Aymane-ST commented Apr 24, 2026 •
edited by fpistm
Loading

Copy link
Copy Markdown

Summary

This PR adds I3C support to LPS22DFSensor.

Main additions

  • I3CBus-based constructor
  • I3C static address constants
  • LPS22DF PID constants
  • register read/write path through I3CBus
  • optional data-ready / IBI helpers

Implemented support

  • basic I3C register access using:
    • readRegBuffer(...)
    • writeRegBuffer(...)
  • support for either:
    • static + dynamic address flow
    • dynamic-address-only flow
  • helper APIs for enabling I3C IBI-based signaling

Files added / updated

  • CMakeLists.txt
  • src/LPS22DFSensor.cpp
  • src/LPS22DFSensor.h

Notes

This PR depends on the I3C Library PR ref:stm32duino/Arduino_Core_STM32#2963

/use-core-repo

@Aymane-ST
Aymane-ST requested review from cparata and fpistm April 24, 2026 15:10
@Aymane-ST Aymane-ST self-assigned this Apr 24, 2026
@fpistm fpistm added the enhancement New feature or request label Apr 27, 2026
fpistm
fpistm reviewed Apr 27, 2026
View reviewed changes

@fpistm fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to add a check for the core version.

#if defined(STM32_CORE_VERSION) && (STM32_CORE_VERSION  <= 0x020C0000)
  #error "This library is not compatible with core version used. Please update the core."
#endif

cparata
cparata reviewed Apr 27, 2026
View reviewed changes

@cparata cparata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me, but I would wait for an official release of the STM32duino Core that integrates the I3C support before integrating this PR. The only thing is about the file CMakeLists.txt: is it mandatory?

cparata
cparata reviewed Apr 27, 2026
View reviewed changes
Comment thread src/lps22df_reg.h Outdated
@Aymane-ST

Aymane-ST commented Apr 27, 2026

Copy link
Copy Markdown
Author

Looks Good To Me, but I would wait for an official release of the STM32duino Core that integrates the I3C support before integrating this PR. The only thing is about the file CMakeLists.txt: is it mandatory?

Hello Carlo, for the CMakeLists.tx is not really mandatory, it's just so the user can compile using CMake easily

@Aymane-ST
Aymane-ST force-pushed the I3C branch 2 times, most recently from fc4b44c to 282f2b0 Compare April 27, 2026 12:59
cparata
cparata approved these changes Apr 27, 2026
View reviewed changes

@cparata cparata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for the official STM32duino Core release before integrating it.

@fpistm
fpistm force-pushed the I3C branch 2 times, most recently from 380bfde to a481641 Compare May 18, 2026 12:40
@fpistm
fpistm requested a review from cparata May 18, 2026 12:47
cparata
cparata requested changes May 18, 2026
View reviewed changes
Comment thread examples/LPS22DF_I3C_Basic/LPS22DF_I3C_Basic.ino
cparata
cparata approved these changes May 18, 2026
View reviewed changes

@cparata cparata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fpistm
fpistm requested changes Jul 3, 2026
View reviewed changes
Comment thread examples/LPS22DF_I3C_Basic/LPS22DF_I3C_Basic.ino Outdated
cparata
cparata approved these changes Jul 10, 2026
View reviewed changes

@cparata cparata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Aymane-ST added 3 commits July 13, 2026 09:56
@Aymane-ST @fpistm
feat(I3C): adding support for I3C
fb032f7 
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
@Aymane-ST @fpistm
chore: ensure stm32 core version is higher than 2.12.0
c383e5f 
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
@Aymane-ST @fpistm
feat(I3C): add I3C examples
5465fd7 
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
@fpistm
ci: enhance compilation step
f171c5a 
Allows to
- use new compile-example feature like /user-core-repo
- compile I3C examples only for boards with I3C support

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@Aymane-ST @fpistm
feat(LPS22DF): guard I3C code with I3C_SUPPORTED
ed4a838 
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
fpistm
fpistm approved these changes Jul 15, 2026
View reviewed changes

@fpistm fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fpistm fpistm mentioned this pull request Jul 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cparata cparata cparata approved these changes
@fpistm fpistm fpistm approved these changes

Assignees

@Aymane-ST Aymane-ST

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aymane-ST @cparata @fpistm