Skip to content

Add scoped whitelist rules and macOS blocking - #2202

Open
AlyaGomaa wants to merge 1 commit into
sebas/feat/instance_lifecycle_commandsfrom
sebas/feat/scoped_whitelist_blocking
Open

AlyaGomaa wants to merge 1 commit into
sebas/feat/instance_lifecycle_commandsfrom
sebas/feat/scoped_whitelist_blocking

Conversation

@AlyaGomaa

@AlyaGomaa AlyaGomaa commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Sub-PR of #2141: part 5 of 12. The parent PR stays open and unchanged; this PR carries one feature of it so it can be reviewed on its own.

What this PR adds

  • Whitelist file: IP + destination port rules, source IP conditions, AirPlay request URI rules and a blocking ignore type that keeps evidence and alerts but exempts the host from blocking and ARP poisoning.
  • Each run loads its local whitelist; comments are kept; Zeek log cleanup no longer deletes the configured whitelist.
  • Organization whitelist: subdomain matching fixed.
  • Prevention on macOS through pf (macos_pf.py); no firewall privilege prompt on shutdown when nothing was blocked.
  • Feed status (feed_status.py): sources, update dates and indicator counts; empty feeds and Redis errors are handled.

Where it sits in the split

Tests

  • Unit suite on this branch (local, pytest tests/unit -n 3): 4180 passed, 2 skipped, 2 failed. Failing: test_native_restart_preserves_arguments_and_waits_for_worker. They fail the same way on the unsplit parent branch in the same local sandbox. Integration tests were not run locally.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#2141 sub-PR Part of the split of PR #2141

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants