Repository navigation
Conversation
This was referenced Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-PR of #2141: part 8 of 12. The parent PR stays open and unchanged; this PR carries one feature of it so it can be reviewed on its own.
What this PR adds
smb_analyzermodule with configurable SMB behavior detection (detector.py,settings.py).smb-behavior.zeek,flows/smb.py) are parsed, stored and retained.smb_analyzersection inconfig/slips.yaml;docs/smb_detection.md.Where it sits in the split
sebas/feat/beaconing_detection(Add beaconing detection and repair RNN C2 processing #2204), so the diff shows only this PR's changes. GitHub retargets it todevelopwhen Add beaconing detection and repair RNN C2 processing #2204 merges.8d6533186.Tests
pytest tests/unit -n 3): 4639 passed, 2 skipped, 2 failed. Failing:test_native_restart_preserves_arguments_and_waits_for_worker. They fail the same way on the unsplit parent branch in the same local sandbox. Integration tests were not run locally.