Skip to content

Fix false positives in existing detectors - #2207

Open
AlyaGomaa wants to merge 1 commit into
sebas/feat/service_anomaly_detectionfrom
sebas/fix/detector_false_positives
Open

AlyaGomaa wants to merge 1 commit into
sebas/feat/service_anomaly_detectionfrom
sebas/fix/detector_false_positives

Conversation

@AlyaGomaa

@AlyaGomaa AlyaGomaa commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Sub-PR of #2141: part 10 of 12. The parent PR stays open and unchanged; this PR carries one feature of it so it can be reviewed on its own.

What this PR adds

  • Connections: broadcast, group and ICMP traffic excluded from long-connection findings; TCP handshake evidence avoids reversed connection findings; port 80 traffic is checked against linked HTTP records first.
  • Private subnet mismatch: one finding per flow, high for the source host and info for the receiving host; subnet checks use the network at capture time.
  • DNS: DGA counts distinct failures; working resolvers and local discovery are excluded from missing-resolution evidence.
  • TLS/HTTP: suspected TLS provider impersonation, HTTP IP hosts, binary content header anomalies, executable downloads raised to medium.
  • SSH password guessing requires authentication failures; Windows NT is no longer matched inside Macintosh user agents.
  • Evidence descriptions state observed facts without recurring disclaimers.

Where it sits in the split

Tests

  • Unit suite on this branch (local, pytest tests/unit -n 3): 5168 passed, 2 skipped, 2 failed. Failing: test_native_restart_preserves_arguments_and_waits_for_worker. They fail the same way on the unsplit parent branch in the same local sandbox. Integration tests were not run locally.

@AlyaGomaa AlyaGomaa self-assigned this Nov 10, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Slips Nov 10, 2026
@AlyaGomaa AlyaGomaa added the #2141 sub-PR Part of the split of PR #2141 label Nov 11, 2026
@AlyaGomaa
AlyaGomaa added this pull request to stack #2210 November 11, 2026 11:53

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#2141 sub-PR Part of the split of PR #2141

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants