Repository navigation
chore: fix the typecheck and clear config deprecations - #220
Merged
Merged
Conversation
- Import the JSX type from React; React 19 no longer has a global JSX namespace. - Move onBrokenMarkdownLinks to markdown.hooks (deprecated in Docusaurus 3.9). - Run the typecheck in the Test workflow. - Drop old Jekyll entries from .gitignore. - Use pnpm in the website README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small maintenance pass.
Changes
pnpm --filter website typecheckfailed withCannot find namespace 'JSX'. React 19 removed the globalJSXnamespace, so the two components now import the type fromreact.onBrokenMarkdownLinkstomarkdown.hooks.onBrokenMarkdownLinks. The old location is deprecated and printed a warning on every build. It goes away in Docusaurus v4..gitignore: removed the Jekyll entries left from before the Docusaurus move.website/README.md: usespnpminstead ofnpm, and describes how deployment really works (the Pages workflow onmain).Checked locally
pnpm buildpasses, with no deprecation warning.pnpm --filter website typecheckpasses.pnpm lintandcspellpass.