Repository navigation
Escape feed names in story list - #1648
Merged
Merged
Conversation
**What**
- Render the feed name in the story template with the escaped
`{{- }}` form instead of raw `{{= }}`.
- Run feed names from OPML imports through `ContentSanitizer`, as
`Feed::Create` already does.
**Why**
Feed names from OPML imports were saved as-is and then inserted
into the story list as raw HTML, so markup in a feed name could
run in the reader's browser.
**Notes**
Names already cleaned by the sanitizer have `&` stored as
`&`, which now shows as `&` in the story list, matching
the feeds page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
{{- }}form instead of raw{{= }}.ContentSanitizer, asFeed::Createalready does.Why
Feed names from OPML imports were saved as-is and then inserted
into the story list as raw HTML, so markup in a feed name could
run in the reader's browser.
Notes
Names already cleaned by the sanitizer have
&stored as&, which now shows as&in the story list, matchingthe feeds page.