Skip to content

Update deprecated EXT_ITER option in test configs - #2866

Open
Syphonicc wants to merge 1 commit into
su2code:developfrom
Syphonicc:update-deprecated-ext-iter
Open

Update deprecated EXT_ITER option in test configs#2866
Syphonicc wants to merge 1 commit into
su2code:developfrom
Syphonicc:update-deprecated-ext-iter

Conversation

@Syphonicc

Copy link
Copy Markdown

EXT_ITER was removed in SU2 v7 and replaced by ITER. These eight configs still used the old name and failed to parse. Values are unchanged; this is a rename only.

All eight verified to run on current develop with a serial build.

Proposed Changes

EXT_ITER was removed in SU2 v7 and replaced by ITER, but eight test configs still used the old name and fail to parse with a "invalid option name" error. This renames the option in each; iteration values are unchanged, so there's no behavioral change.

Files updated:

control_surface/inv_ONERAM6_moving.cfg
control_surface/inv_ONERAM6_setting.cfg
euler/CRM/inv_CRM_JST.cfg
euler/channel/inv_channel.cfg
navierstokes/naca0012/lam_NACA0012.cfg
rans/flatplate/turb_SST_flatplate.cfg
rans/s809/turb_S809.cfg
rans_uq/naca0012/turb_NACA0012_uq.cfg

All eight were run locally on current develop (serial build) and start and converge normally.

Two things I noticed while doing this, not addressed here , happy to open separate issues if useful:

Several other configs have further deprecated options (FROZEN_VISC, REF_LENGTH_MOMENT, GEO_AXIS_STATIONS, SOLUTION_LIN_FILENAME) and some have solver/turbulence-model settings that no longer validate.
The hom_euler test cases reference mesh files that don't appear to exist in either the SU2 or TestCases repos, so those can't be run or verified.

Related Work

None.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [X ] I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

EXT_ITER was removed in SU2 v7 and replaced by ITER. These eight
configs still used the old name and failed to parse. Values are
unchanged; this is a rename only.

All eight verified to run on current develop with a serial build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant