Conversation
Report model 0 for legacy hwOS devices and retain the OSTC 4 and OSTC 5 model bytes. Keep hardware identifiers separate so only their unique descriptors can refine the selected product. Signed-off-by: Michael Keller <github@ike.ch>
Keep the established HW OSTC3 product resolution in the hardware-ID refinement map while device-info model values follow the protocol. Signed-off-by: Michael Keller <github@ike.ch>
6 tasks
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Restores hwOS model semantics while preserving Heinrichs Weikamp product identification through hardware-ID refinement.
Changes:
- Reports legacy model
0, with OSTC 4/5 models0x43/0x44. - Adds hardware-ID mappings for 11 Heinrichs Weikamp devices.
- Preserves unsupported five-byte
HARDWARE2responses.
File summaries
| File | Description |
|---|---|
src/hw_ostc3.c |
Updates model reporting, hardware requests, and device-info hardware IDs. |
src/descriptor.c |
Adds hardware-ID product refinement and coarse hwOS descriptors. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore upstream hwOS device-info model semantics while retaining the existing Heinrichs Weikamp product resolution through the generic hardware-ID refinement path.
0for legacy hwOS devices, with0x43and0x44for OSTC 4 and OSTC 5.HARDWARE2requests.Testing
dc_descriptor_find_by_hw_id()lookup test covering 11 Heinrichs Weikamp hardware IDs.ctest --output-on-failure(34/34 passed).