Repository navigation
Conversation
Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the fork-to-exec signal race reported in #566. Signals remain blocked across the command fork; the child restores the saved signal dispositions before restoring its signal mask, so a forwarded signal stays pending until the command can receive it. This also preserves signals that were ignored by sudo\x27s caller.
Thanks to @pepa-cz for the detailed analysis and reproducer in #566; this implements the approach described there.
Validation on Fedora 44 aarch64 (kernel 7.2.6), building in an Ubuntu 24.04 arm64 container:
make checkpasses.use_pty(0 lost SIGTERMs).