Repository navigation
feat: integrate public SUN SDK into sun-cli v2.0.0 - #89
Open
felix-tron wants to merge 12 commits into
Open
felix-tron wants to merge 12 commits into
felix-tron wants to merge 12 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grayfoxd
reviewed
Oct 23, 2026
grayfoxd
reviewed
Oct 23, 2026
grayfoxd
reviewed
Oct 23, 2026
grayfoxd
reviewed
Oct 23, 2026
- restore ABI discovery, Shasta generic calls and custom ABI support - preserve SunPump min-out, API endpoint and transaction output - align V3/V4 liquidity behavior with pre-migration implementation - upgrade SUN SDK dependencies to 0.1.1-beta.1 - add compatibility regression tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Prepare sun-cli 2.0.0 by replacing
@sun-protocol/sun-kitand local protocol implementations with the public modular SUN SDK packages. Preserve the existing command interface and transaction parameter semantics while moving the underlying execution to SUN SDK.Changes
txidresult structure, wallet output fields, and SunPump's Mainnet-only restriction.500and an automatic tick range derived from the current pool tick, extending 100 tick spacings in each direction. Preserve explicit fee and tick inputs, including tick0.sun-kitdependency and local SunPump implementation with public SUN SDK packages.^22.23.4 || ^24.22.1; run CI on the latest Node 22.x and 24.x patches and add lint checks.2.0.0-beta.0. The target stable release is2.0.0.Validation
Current review fixes
c4f2072(Node 22.x, Node 24.x, and lint).Historical published-package regression
1.2.2and1.2.3-beta.0each completed 11 successful Nile transactions, for 22 successful transactions in total.1.2.3-beta.1completed two additional successful Nile Swap transactions, with quotes, calldata, transfer events, and received amounts verified.2.0.0-beta.0test or on-chain validation of the subsequent V4 default-parameter fixes.Remaining release steps
0.1.1-beta.0; stable0.1.1is not yet published. Update all direct SDK dependencies and the lockfile after the approved stable SDK release is available.2.0.0.