Skip to content

fix(stack): group database helper containers with their stack - #6870

Merged
avallete merged 6 commits into
developfrom
avallete/stack-db-helper-group
Sep 29, 2026
Merged

avallete merged 6 commits into
developfrom
avallete/stack-db-helper-group

Conversation

@avallete

Copy link
Copy Markdown
Member

Summary

TL;DR: This builds on #6867, which groups a stack's containers as one compose project in Docker Desktop and OrbStack. The database storage helper containers (supabase-db-helper-*) were still left outside that group. They now join their stack's compose project as the database-helper service.

Stacked on #6867; merge that first.

Before

flowchart LR
  G["Compose project supabase-myapp-…"] --> S["studio, rest, database …"]
  H["supabase-db-helper-…"] --> U["Ungrouped in Docker Desktop/OrbStack"]
Loading

After

flowchart LR
  G["Compose project supabase-myapp-…"] --> S["studio, rest, database …"]
  G --> H["supabase-db-helper-…<br/>service: database-helper"]
Loading

What changed

  • A shared composeProjectFor in runtime/ContainerName.ts derives the compose project for both the stack's service containers and its helpers.
  • The database storage receives the project folder name. Both the per-instance helper and the shared volume helper get com.docker.compose.project and com.docker.compose.service=database-helper.
  • Helper names and existing com.supabase.* labels are unchanged. Helpers carry no com.supabase.service label, so service log collectors skip them.

Linked issue

None.

🤖 Generated with Claude Code

avallete and others added 3 commits September 28, 2026 20:52
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and containers

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@avallete
avallete requested a review from a team as a code owner September 28, 2026 21:32

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews reported no findings. I checked the changed code and its surrounding call paths and found no actionable issue: database containers and storage helpers use the same compose project name, and the helper labels are applied on both creation paths.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

avallete and others added 2 commits September 29, 2026 07:57
…cape the name filter

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base automatically changed from avallete/stack-container-names to develop September 29, 2026 06:13
…helper-group

# Conflicts:
#	packages/stack/src/runtime/ContainerName.ts
@avallete
avallete enabled auto-merge September 29, 2026 07:36
@avallete
avallete added this pull request to the merge queue Sep 29, 2026
Merged via the queue into develop with commit 2547ce5 Sep 29, 2026
29 checks passed
@avallete
avallete deleted the avallete/stack-db-helper-group branch September 29, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants