fix(stack): group database helper containers with their stack - #6870
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and containers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews reported no findings. I checked the changed code and its surrounding call paths and found no actionable issue: database containers and storage helpers use the same compose project name, and the helper labels are applied on both creation paths.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
…cape the name filter Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…into avallete/stack-db-helper-group
…helper-group # Conflicts: # packages/stack/src/runtime/ContainerName.ts
jgoux
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TL;DR: This builds on #6867, which groups a stack's containers as one compose project in Docker Desktop and OrbStack. The database storage helper containers (
supabase-db-helper-*) were still left outside that group. They now join their stack's compose project as thedatabase-helperservice.Stacked on #6867; merge that first.
Before
After
What changed
composeProjectForinruntime/ContainerName.tsderives the compose project for both the stack's service containers and its helpers.com.docker.compose.projectandcom.docker.compose.service=database-helper.com.supabase.*labels are unchanged. Helpers carry nocom.supabase.servicelabel, so service log collectors skip them.Linked issue
None.
🤖 Generated with Claude Code