Repository navigation
test(cli-e2e): add external_email_magic_link_disabled to auth config fixtures - #7601
Conversation
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 8 commands. Binary size: 134.8 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed. All eight fixtures contain the same false-valued field addition and otherwise preserve their JSON content. No confirmed defects were found. Claude’s cosmetic key-order finding remains uncertain because the upstream response order could not be verified.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli-e2e/fixtures/recorded/GET_v1_projects_replayfixtureprojref_config_auth/default.response.json:214 |
fixture-consistency |
claude | Placing external_email_magic_link_disabled between security_sb_forwarded_for_enabled and security_captcha_enabled may cause unnecessary key movement during a future fixture re-recording. The same placement appears in all eight fixtures. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 1
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
The Management API sync makes
external_email_magic_link_disableda required field in the auth config response, so replayed fixtures without it fail to decode andconfig pushexits 1. Adding the field to the recorded and scenario fixtures first lets the sync PR pass; unknown fields are ignored by the current schema, so this is safe before the sync lands.