Skip to content

test(cli-e2e): add external_email_magic_link_disabled to auth config fixtures - #7601

Merged
jgoux merged 1 commit into
developfrom
test/cli-e2e-magic-link-fixtures
Nov 12, 2026
Merged

jgoux merged 1 commit into
developfrom
test/cli-e2e-magic-link-fixtures

Conversation

@jgoux

@jgoux jgoux commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

The Management API sync makes external_email_magic_link_disabled a required field in the auth config response, so replayed fixtures without it fail to decode and config push exits 1. Adding the field to the recorded and scenario fixtures first lets the sync PR pass; unknown fields are ignored by the current schema, so this is safe before the sync lands.

@jgoux
jgoux requested a review from a team as a code owner November 12, 2026 13:04
@jgoux
jgoux requested a review from avallete November 12, 2026 13:04
@jgoux jgoux self-assigned this Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLI benchmark (Lightweight Commands): no changes found

Commit a504c1b against develop at 5c800b0 · 10 runs each · report only, never blocks merging

Command Workload Before After Change
supabase --version version 203 ms 204 ms no real change
supabase --help help 212 ms 218 ms no real change
supabase init init 204 ms 199 ms no real change
supabase migration new bench migration-new 242 ms 250 ms no real change
supabase config convert config-convert 231 ms 239 ms no real change
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 278 ms 276 ms no real change
supabase projects list projects-list 274 ms 289 ms no real change (+5%, within normal variation)
supabase functions list --project-ref replayfixtureprojref functions-list 275 ms 266 ms no real change

API calls: unchanged for all 8 commands.

Binary size: 134.8 MB, unchanged.

Details: timing ranges, API calls per command, slowest phases

Timing ranges

Command Workload Before range After range Change Verdict
supabase --version version 174-267 ms 174-249 ms +1 ms (+0%) within noise
supabase --help help 197-251 ms 200-264 ms +5 ms (+2%) within noise
supabase init init 177-233 ms 171-231 ms -6 ms (-3%) within noise
supabase migration new bench migration-new 203-293 ms 214-340 ms +8 ms (+3%) within noise
supabase config convert config-convert 216-243 ms 221-293 ms +7 ms (+3%) within noise
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 249-315 ms 256-304 ms -2 ms (-1%) within noise
supabase projects list projects-list 260-314 ms 258-333 ms +15 ms (+5%) within noise
supabase functions list --project-ref replayfixtureprojref functions-list 255-360 ms 251-289 ms -9 ms (-3%) within noise

API calls per command

Command Workload Before After Endpoint changes
supabase --version version 0 0
supabase --help help 0 0
supabase init init 0 0
supabase migration new bench migration-new 0 0
supabase config convert config-convert 0 0
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 2 2
supabase projects list projects-list 1 1
supabase functions list --project-ref replayfixtureprojref functions-list 2 2

Slowest phases

No command moved beyond noise, so there are no phase deltas.

Workflow run

Comment /bench to run the lightweight benchmark (this comment) again on the latest commit, or /bench full to also run the integration-heavy benchmark, which posts in its own comment.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews completed. All eight fixtures contain the same false-valued field addition and otherwise preserve their JSON content. No confirmed defects were found. Claude’s cosmetic key-order finding remains uncertain because the upstream response order could not be verified.

Findings

Severity Location Category Sources Claim
⚪ NIT apps/cli-e2e/fixtures/recorded/GET_v1_projects_replayfixtureprojref_config_auth/default.response.json:214 fixture-consistency claude Placing external_email_magic_link_disabled between security_sb_forwarded_for_enabled and security_captcha_enabled may cause unnecessary key movement during a future fixture re-recording. The same placement appears in all eight fixtures.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 1


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@jgoux
jgoux added this pull request to the merge queue Nov 12, 2026
Merged via the queue into develop with commit f689c30 Nov 12, 2026
59 checks passed
@jgoux
jgoux deleted the test/cli-e2e-magic-link-fixtures branch November 12, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants