Skip to content

chore(stack): report the container state when docker start times out - #7602

Merged
jgoux merged 1 commit into
developfrom
chore/stack-start-timeout-state
Nov 12, 2026
Merged

jgoux merged 1 commit into
developfrom
chore/stack-start-timeout-state

Conversation

@jgoux

@jgoux jgoux commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

The Docker idle and wake e2e occasionally fails with Engine command 'start' did not finish within 30s and empty stderr, which does not say whether the engine stalled before or after starting the process. When start times out, the launch error now includes the container's status, start time, pid, and engine error from docker inspect, so the next failure shows where it stalled.

@jgoux
jgoux requested a review from a team as a code owner November 12, 2026 13:29
@jgoux
jgoux requested a review from kanadgupta November 12, 2026 13:29
@jgoux jgoux self-assigned this Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLI benchmark (Lightweight Commands): no changes found

Commit 6bb5dfc against develop at 5c800b0 · 10 runs each · report only, never blocks merging

Command Workload Before After Change
supabase --version version 203 ms 199 ms no real change
supabase --help help 245 ms 231 ms no real change (-6%, within normal variation)
supabase init init 189 ms 196 ms no real change
supabase migration new bench migration-new 193 ms 187 ms no real change
supabase config convert config-convert 236 ms 231 ms no real change
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 253 ms 259 ms no real change
supabase projects list projects-list 252 ms 253 ms no real change
supabase functions list --project-ref replayfixtureprojref functions-list 252 ms 244 ms no real change

API calls: unchanged for all 8 commands.

Binary size: 134.8 MB, unchanged.

Details: timing ranges, API calls per command, slowest phases

Timing ranges

Command Workload Before range After range Change Verdict
supabase --version version 174-319 ms 173-236 ms -4 ms (-2%) within noise
supabase --help help 201-300 ms 193-300 ms -15 ms (-6%) within noise
supabase init init 169-213 ms 168-225 ms +7 ms (+4%) within noise
supabase migration new bench migration-new 179-244 ms 172-250 ms -5 ms (-3%) within noise
supabase config convert config-convert 192-323 ms 214-336 ms -5 ms (-2%) within noise
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 233-281 ms 239-283 ms +6 ms (+2%) within noise
supabase projects list projects-list 223-360 ms 210-361 ms +1 ms (+1%) within noise
supabase functions list --project-ref replayfixtureprojref functions-list 232-311 ms 213-317 ms -8 ms (-3%) within noise

API calls per command

Command Workload Before After Endpoint changes
supabase --version version 0 0
supabase --help help 0 0
supabase init init 0 0
supabase migration new bench migration-new 0 0
supabase config convert config-convert 0 0
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 2 2
supabase projects list projects-list 1 1
supabase functions list --project-ref replayfixtureprojref functions-list 2 2

Slowest phases

No command moved beyond noise, so there are no phase deltas.

Workflow run

Comment /bench to run the lightweight benchmark (this comment) again on the latest commit, or /bench full to also run the integration-heavy benchmark, which posts in its own comment.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Confirmed the sole finding: the diagnostic inspect failure/timeout fallback lacks test coverage. Code inspection found no additional correctness issues. Both independent reviews were available.

Findings

Severity Location Category Sources Claim
⚪ NIT packages/stack/src/runtime/Container.ts:1062 test-coverage claude No test covers diagnostic inspect failing or timing out after start times out. The existing test only exercises successful inspection, leaving preservation of the original timeout through the unavailable fallback unverified.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Comment thread packages/stack/src/runtime/Container.ts Resolved
@jgoux
jgoux added this pull request to the merge queue Nov 12, 2026
Merged via the queue into develop with commit 2aa8516 Nov 12, 2026
55 checks passed
@jgoux
jgoux deleted the chore/stack-start-timeout-state branch November 12, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants