Repository navigation
Conversation
Re-port the effect patch to 4.1.4 and adapt to two 4.1.3 changes: - Param annotations now hold a self-referential Context, so the config-flag binding walk stops at Param nodes. - Flag.withDefault now records its default as a Transform fallback, which permission conditions read for flag defaults.
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 8 commands. Binary size: 134.9 MB, up 44.0 KB from 134.8 MB. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. Confirmed Claude’s documentation nit about stale test names; no additional concrete defects were identified. Dependencies are absent, so tests were not run.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/command-internal/param-introspection.unit.test.ts:21 |
documentation |
claude | Two test names still describe Flag.withDefault as a Map/Optional chain, although the upgrade uses a Transform with a Default fallback. |
Findings outside the diff
- ⚪ NIT
apps/cli/src/command-internal/param-introspection.unit.test.ts:21— Two test names still describe Flag.withDefault as a Map/Optional chain, although the upgrade uses a Transform with a Default fallback.
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Summary
Bumps
effect,@effect/platform-bun,@effect/platform-node,@effect/sql-pgand@effect/vitestfrom 4.1.2 to 4.1.4.Patches
effect: every hunk is still needed, because none were fixed upstream. TheCommand.jstoShowHelpremoval no longer applied, so it was re-applied on the new code. TheTODO(CLI-2922)help doc shape is kept.@effect/platform-node-sharedand@effect/vitest: renamed to 4.1.4, with unchanged content.Changes forced by the bump
Paramnodes; before this, it overflowed the stack.Flag.withDefaultnow records its default as aTransformfallback (4.1.3). Permission conditions read flag defaults from there, which keeps the "or unset" wording ingen types --help.packages/stackincludes Effect's code, so it is regenerated.Changes visible to users
Help output is unchanged. Shell completions pick up two upstream 4.1.3 fixes:
--schema,--excludeand--sql-pathsare offered again after they have been used once._supabase--choiceshelper instead ofcompgen -W.