Repository navigation
Conversation
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 8 commands. Binary size: 134.8 MB, up 4.0 KB from 134.8 MB. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
🤖 AI Review
Verified both reviews against the checked-out code. Claude’s sole finding is a confirmed style nit; Codex reported no findings. Static review identified no functional defects.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/auth/command-credentials.layer.ts:463 |
style |
claude | The new explanatory comment uses /* ... */, whereas the file’s other non-JSDoc comments use //. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
TL;DR
supabase bootstrapon macOS asked for the keychain password up to 4 times, now it asks oncewhat broke?
every part of the cli that needs your access token read it from the keychain again instead of reusing the first read
one
bootstraprun does that 4-7 times, andsecrets list,projects api-keys,projects listandorgs list2 to 3 timesmacOS counts each read as a new access, so anyone who clicks Allow instead of Always Allow gets a password prompt for every one of them
now fixed by:
reading the keychain once and sharing that token with every caller in the same run
login, logout and the credentials sweep clear it so a new or removed token is picked up right away, and
--debugoutput stays the sameref: