Repository navigation
Conversation
Collaborator
Author
|
Draft to see if clang12 works or not. |
Package version diff: none (aarch64-linux, x86_64-linux) |
We only import nixpkgs-oldstable to take v8 from it, and never use its flake outputs. Mark it flake = false so Nix treats it as a source snapshot and skips its flake.nix. The locked source and its hash do not change. Not a big deal in the end but a nice signal imo. Also drop config.allowUnfree from that import. v8 is BSD-3-Clause, and it and its build inputs evaluate without it on every system. Also drop permittedInsecurePackages from the main nixpkgs import. It sat next to config instead of inside it, so nixpkgs ignored it. It named the v8 we now take from nixpkgs-oldstable, which the main nixpkgs no longer has and which has no known vulnerabilities. Assisted-by: Claude <noreply@anthropic.com>
Old pgrx versions (before 0.11.3) need clang and glibc headers from nixos-22.11 to build. We got them by downloading the whole nixos-22.11 tarball with fetchTarball during every eval. That was slow and could not use the flake lock or eval cache. Add nixos-22.11 as a non-flake input instead and take clang from it. It locks to the final 22.11 release, so the build outputs are the same as before and still come from the binary cache. Keep using it on every platform, so each extension version builds with the same clang everywhere. Newer clang and glibc break the old bindgen versions these pgrx releases use: bindgen 0.60.x panics on how clang 16 and later name anonymous structs, which glibc and macOS SDK headers contain. On aarch64-linux, bindgen also fails on the ARM NEON vector functions that newer glibc headers declare, even with clang 12. Assisted-by: Claude <noreply@anthropic.com>
mmlb
force-pushed
the
push-kmzzzuxtppqt
branch
from
November 12, 2026 21:11
1eebb97 to
ae6db08
Compare
PostgreSQL Extension Dependency Analysis: PR #2647
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2647
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
mmlb
changed the title
Collaborator
Author
|
clang12 does not work :( https://github.com/supabase/postgres/actions/runs/43295401848 |
mmlb
marked this pull request as ready for review
November 12, 2026 21:24
mmlb
enabled auto-merge
November 12, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Gardening
What is the current behavior?
We fetch nixpkgs-22.11 during nix eval, every eval.
What is the new behavior?
We don't do that any more, making eval go slightly faster.