Skip to content

ci: pin actions to commit SHAs and declare GITHUB_TOKEN permissions - #26

Merged
anglinb merged 1 commit into
mainfrom
ci/pin-actions-token-permissions
Nov 12, 2026
Merged

anglinb merged 1 commit into
mainfrom
ci/pin-actions-token-permissions

Conversation

@anglinb

@anglinb anglinb commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

The superwall org is about to turn on two Actions policies: require actions to be pinned to a full-length commit SHA and read-only default GITHUB_TOKEN permissions. Either policy breaks workflows that aren't ready, so this PR gets this repo ready first.

What changed

  • Every non-local uses: (actions, reusable workflows, composite-action internals) is pinned to the commit SHA its current tag or branch resolves to, with the version kept as a trailing comment (uses: actions/checkout@<sha> # v4). No versions were changed; annotated tags were dereferenced to their commit.
  • Workflows that relied on the org's read/write default now declare permissions: explicitly, with the minimum each job uses today (contents: read unless a job pushes, comments, creates deployments, etc.).

Permission grants I was unsure about

  • unity.yml test job: granted checks: write because game-ci/unity-test-runner is given githubToken to publish a test-results check.

🤖 Generated with Claude Code

The superwall org is turning on "require actions to be pinned to a full-length
commit SHA" and a read-only default GITHUB_TOKEN.

- Pin every non-local `uses:` (actions, reusable workflows, composite action
  internals) to the commit its current tag or branch resolves to, keeping the
  version as a trailing comment. No version changes.
- Add explicit `permissions:` to workflows that relied on the org's read/write
  default, granting only the scopes each job uses today.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@maple-review-bot

This comment has been minimized.

@anglinb
anglinb force-pushed the ci/pin-actions-token-permissions branch from 215497d to dd271ac Compare November 12, 2026 06:41
@maple-review-bot

maple-review-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. The workflow-only changes are unchanged since the prior review, with no open findings and no production behavior added.
no findings · tests not needed · risk low

Pins external GitHub Actions to commit SHAs and declares read-only token permissions, with check-writing access for Unity tests. No new defects found in the unchanged revision.

dd271ac · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@anglinb
anglinb merged commit 149e27e into main Nov 12, 2026
5 checks passed
@anglinb
anglinb deleted the ci/pin-actions-token-permissions branch November 12, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant