Conversation
Motivation: HTTPClientError.localizedDescription currently falls back to Foundation’s generic error 1 message, obscuring the underlying failure. Modifications: Conform HTTPClientError to LocalizedError using its existing description and add coverage for errors with and without associated values. Result: localizedDescription now preserves the concrete HTTP client error details.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
HTTPClientError.localizedDescription currently falls back to Foundation’s generic error 1 message, which hides the underlying AsyncHTTPClient failure.
Fixes #797.
Modifications
Result
localizedDescription now reports the concrete HTTP client error and preserves diagnostic associated values.
Testing