Skip to content

Reject the empty header field name #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avalyset wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reject the empty header field name #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/AsyncHTTPClient/RequestValidation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ extension HTTPHeaders {

private func validateFieldNames() throws {
let invalidFieldNames = self.compactMap { name, _ -> String? in
// [RFC 9110](https://www.rfc-editor.org/rfc/rfc9110.html#name-field-names) defines
// `field-name = token`, and `token = 1*tchar`, so a field name must contain at least
// one character. `allSatisfy` alone is true for the empty name.
guard !name.isEmpty else { return name }

let satisfy = name.utf8.allSatisfy { char -> Bool in
switch char {
case UInt8(ascii: "a")...UInt8(ascii: "z"),
Expand Down
13 changes: 13 additions & 0 deletions Tests/AsyncHTTPClientTests/RequestValidationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,19 @@ class RequestValidationTests: XCTestCase {
}
}

func testEmptyHeaderFieldNameIsRejected() {
// RFC 9110 defines `field-name = token` and `token = 1*tchar`, so the empty
// name is not a valid field name.
var headers = HTTPHeaders([
("", "Haha")
])

XCTAssertThrowsError(try headers.validateAndSetTransportFraming(method: .GET, bodyLength: .known(0))) {
error in
XCTAssertEqual(error as? HTTPClientError, HTTPClientError.invalidHeaderFieldNames([""]))
}
}

func testValidHeaderFieldNames() {
var headers = HTTPHeaders([
("abcdefghijklmnopqrstuvwxyz", "Haha"),
Expand Down