Repository navigation
Reject duplicate headers in dictionary views - #147
Open
rupayon123 wants to merge 1 commit into
Open
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate header names currently lose columns when CSV rows are represented as dictionaries. Reject them with
CSVParseError.duplicateHeader(name:)in dictionary-backed views and enumeration, while keepingCSV<Enumerated>available for repeated headers whose columns remain positionally distinct.Added regressions for
CSV<Named>, dictionary enumeration and the enumerated view using the translation CSV shape from #134. The enumerated-view test verifies that both columns namedenare retained.Closes #134.
Validation recorded on October 3:
Current head:
a8b15cf46c5fb27ca85755978879d53ee4392418. The exact-head Swift Actions run requires maintainer approval; remote tests have not run. No maintainer acceptance is claimed.