Skip to content

Restore Windows modifier overlay window - #574

Merged
enaboapps merged 3 commits into
mainfrom
codex/fix-windows-modifier-overlay-lifecycle
Aug 11, 2026
Merged

Restore Windows modifier overlay window#574
enaboapps merged 3 commits into
mainfrom
codex/fix-windows-modifier-overlay-lifecycle

Conversation

@enaboapps

Copy link
Copy Markdown
Contributor

Summary

  • move the initially visible Windows modifier WebView away from Windows' (-32000, -32000) minimized-window sentinel
  • explicitly restore the modifier window before moving and showing it
  • cover the safe off-screen bootstrap policy with a regression test

Root cause

Alpha 4 made the Windows modifier WebView initially visible so WebView2 would initialize, but positioned it at (-32000, -32000). Windows uses that placement for minimized windows. The packaged app could therefore initialize the page while leaving the later presentation path unable to produce a visible window.

Installed Alpha 4 inspection matched that failure: the main Tauri window and native cursor-overlay windows existed, but no presentable modifier-overlay Tauri window appeared after the field test.

Validation

  • npm run lint
  • npm test (57 tests)
  • npm run build
  • cargo fmt --manifest-path src-tauri/Cargo.toml --check
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warnings
  • cargo test --manifest-path src-tauri/Cargo.toml (133 tests)

Closes #568

@enaboapps
enaboapps marked this pull request as ready for review August 11, 2026 08:00
@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown

Greptile Summary

Summary

Windows modifier-overlay startup now places its visible WebView bootstrap beyond the virtual desktop boundary and restores the window before showing it during a control session. The negative-coordinate monitor layout was exercised with a desktop ending at x=0; the overlay started at x=16, so it does not overlap the display.

Confidence Score: 5/5

No blocking failure remains.

No accepted blocking findings remain.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex ran the requested contract verification for the pull request, and both verification runs reported that local artifact references were not uploaded.

T-Rex Ran code and verified through T-Rex

Reviews (2): Last reviewed commit: "Keep bootstrap policy portable" | Re-trigger Greptile

Comment thread src-tauri/src/modifier_overlay.rs Outdated
@enaboapps
enaboapps merged commit 6af441c into main Aug 11, 2026
4 checks passed
@enaboapps
enaboapps deleted the codex/fix-windows-modifier-overlay-lifecycle branch August 11, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix modifier overlay visibility on Windows

2 participants