feat: persist hardware activities#1044
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
f3f9a2c to
435d9b0
Compare
|
Status update:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Addressed this Android-side gating issue: watcher state now updates before Core persistence, so the Trezor balance/activity UI stays live even if a Core upsert fails. Persistence failures are still logged with the watcher id, and received-transaction emission remains behind successful persistence. Validation: The migration/collision and transfer dedup points remain broader draft follow-ups outside this scoped fix. Resolved in f546f58 |
|
Set milestone to |
708cd21 to
794722a
Compare
ea9a252 to
5ae816a
Compare
The branch is now rebased on the merged #1062 and latest I reran the full Bridge flow on the current head with two independently funded and mined hardware receives. Both appeared once with the correct wallet scope, and list tabs, tags, tag filtering, Activity Detail, and Explore all used the persisted entries. Transfer-to-spending now reconciles the watcher-created sent activity with the transfer metadata. The Bridge run showed one pending This work remains scoped to Resolved in 5ae816a |
This comment has been minimized.
This comment has been minimized.
|
AFAIU this needs a new agent run to make sure it builds correctly on top of latest merges into master and doesn't try to reinvent wheels that have been added in the meantime. |
0d7d218 to
15b80fa
Compare
Indeed, most of these changes were already implemented |
15b80fa to
b4bbc26
Compare
I rebuilt the branch from current Resolved in b4bbc26 |
Closes #1029
Refs #998
Description
This PR:
bitkit-coreunder the wallet ID already derived and stored bymaster.bitkit-coreactivity model and the existingHwWalletId/KnownDeviceidentity path across watcher events, navigation, detail loading, tags, seen state, boost relationships, and deletion.Transfer / From Savingsrow represents the funding transaction.Preview
No visual redesign. Home, All Activity, Activity Detail, tag filtering, and Explore now render the wallet-scoped hardware activities supplied by
bitkit-core.QA Notes
Manual Tests
Transfer / From Savingsrow and its detail showsTO SPENDING.regression:app on-chain and LN activity → Activity Detail, tags, Explore, and wallet-specific lists: behavior matchesmaster.Automated Checks
HwWalletRepoTest.kt,ActivityRepoTest.kt, andTransferRepoTest.ktcover active watcher ownership, Core snapshot persistence, persistence recovery, wallet removal, transfer metadata, and activity/transaction ID collisions across wallet scopes.ActivityDetailViewModelTest.kt,ActivityListViewModelTest.kt,AppViewModelSendFlowTest.kt, andTransferViewModelTest.ktcover scoped detail/tag calls, global unified listing, scoped navigation, hardware notification routing, and Transfer To Spending ownership.NotifyPaymentReceivedHandlerTest.ktandBoostTransactionViewModelTest.ktretain default-wallet behavior with the scoped repository API.activity-blue-icons.xmlandtransfer-to-spending.xml;activity-detail-hw-tags.xmladds persisted tag and inputs/outputs coverage.just compile,just test(1,619 tests), andjust lintpassed; all hardware-wallet journey XML files passedxmllint.