feat: add boltz savings swap#1081
Open
coreyphillips wants to merge 11 commits into
Open
Conversation
coreyphillips
force-pushed
the
feat/savings-swap
branch
from
July 15, 2026 12:44
cd6afdc to
45fce11
Compare
coreyphillips
marked this pull request as ready for review
July 16, 2026 12:58
Greptile SummaryThis PR adds a Boltz reverse-swap path for moving Lightning funds into on-chain savings. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| app/src/main/java/to/bitkit/viewmodels/TransferViewModel.kt | Owns swap execution beyond the screen lifecycle, prevents concurrent starts, cancels stale quote requests, and subscribes before invoice payment. |
| app/src/main/java/to/bitkit/viewmodels/WalletViewModel.kt | Starts claim event collection before the update stream, retries stream startup, and stops updates with the wallet lifecycle. |
| app/src/main/java/to/bitkit/ui/screens/transfer/SavingsProgressScreen.kt | Observes swap outcomes and displays pending claims as settling rather than completed. |
| app/src/main/java/to/bitkit/ui/screens/transfer/SavingsConfirmScreen.kt | Adds swap quotes, amount controls, fee details, and channel-close fallback behavior. |
| app/src/main/java/to/bitkit/services/BoltzService.kt | Wraps Boltz swap creation, queries, claims, refunds, and lifecycle event streaming. |
Reviews (2): Last reviewed commit: "fix: fall back to close when swap amount..." | Re-trigger Greptile
9 tasks
piotr-iohk
marked this pull request as draft
July 21, 2026 06:09
piotr-iohk
marked this pull request as ready for review
July 21, 2026 06:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a swap-based path for transferring spending balance to savings, so Lightning funds can move on-chain through a Boltz reverse swap instead of only by closing a channel.
Description
Preview
QA Notes
Manual Tests (Must use mainnet for now)
regression:Savings Confirm → Close channel instead: falls back to the channel-close path.regression:Start the app with a pending swap: swap resumes and balance updates once it lands on-chain.Automated Checks
TransferViewModelTest.kt.SwapsViewModelTest.kt.WalletViewModelTest.kt.compileDevDebugKotlin,testDevDebugUnitTest, anddetektall pass.